Reject network account mutations in RPC#2252
Open
AlgofootPrint wants to merge 42 commits into
Open
Conversation
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
Co-authored-by: Bobbin Threadbare <43513081+bobbinth@users.noreply.github.com>
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
Co-authored-by: Mirko von Leipzig <48352201+Mirko-von-Leipzig@users.noreply.github.com>
…afana (0xMiden#1948) Co-authored-by: Krisztian Kovacs <krisztian.k@miden.team> Co-authored-by: SantiagoPittella <pittellasantiago@gmail.com>
Co-authored-by: Mirko von Leipzig <48352201+Mirko-von-Leipzig@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: igamigo <ignacio.amigo@lambdaclass.com>
…en#1986) Co-authored-by: Santiago Pittella <87827390+SantiagoPittella@users.noreply.github.com> Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
…ng is not required (0xMiden#2005) Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com> Co-authored-by: Bobbin Threadbare <43513081+bobbinth@users.noreply.github.com>
…ntext LargeSmt operations that touch RocksDB (open, open_at, open_latest, compute_mutations, apply_mutations, get_block_num, get_latest_commitment, contains_account_id_prefix_in_latest) can block the current thread for disk I/O. Calling them directly in async functions while holding tokio RwLock guards starves the async runtime. Wrapping with tokio::task::block_in_place signals to the runtime that the current thread may block, allowing it to move other tasks off the thread pool while the guard remains valid on the same thread. Fixes 0xMiden#1969.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2146.
Testing
git diff --checkpasses, with line-ending warnings onlycargo test -p miden-node-rpc server::api::testscould not complete becausemiden-node-proto-buildfailed first:file 'C:\Users\damio\Desktop\PR\node\proto\proto\remote_prover.proto' is not in any include path