fix(store/loader): cross-check blockchain MMR consistency with latest block header#2247
Open
kkovaacs wants to merge 3 commits into
Open
fix(store/loader): cross-check blockchain MMR consistency with latest block header#2247kkovaacs wants to merge 3 commits into
kkovaacs wants to merge 3 commits into
Conversation
block header `chain_commitment` in the latest header at height N should be consistent with the MMR peaks at height N (block chain state before block N). This is enforced by `apply_block` when applying a new block. This commit adds a check so that we also enforce this when loading the store.
Mirko-von-Leipzig
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chain_commitmentin the latest header at height N should be consistent with theMMR peaks at height N (block chain state before block N).
This is enforced by
apply_blockwhen applying a new block. This PR adds acheck so that we also enforce this when loading the store. The check compares the loaded MMR at the latest header’s checkpoint:
against:
Closes #2241
Changelog