Skip to content

chore: store account in the actor's context#2194

Merged
Mirko-von-Leipzig merged 13 commits into
nextfrom
santiagopittella-in-memory-accounts
Jun 13, 2026
Merged

chore: store account in the actor's context#2194
Mirko-von-Leipzig merged 13 commits into
nextfrom
santiagopittella-in-memory-accounts

Conversation

@SantiagoPittella

@SantiagoPittella SantiagoPittella commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

closes #2177

This PR removes the query to get the account before executing transactions, and keep the account state in the actor's context. When a transaction targeting the account gets submitted, we do a query to check that it is the expected tx ID. Otherwise we re-fetch the account with the valid state.

Changelog

changelog = "none"
reason    = "Internal change only."

@SantiagoPittella SantiagoPittella added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Jun 3, 2026
@Mirko-von-Leipzig

Copy link
Copy Markdown
Collaborator

@SantiagoPittella sorry I will get to reviewing this; I'm just drowning in getting v0.15 rc out the door.

Comment thread bin/ntx-builder/src/actor/execute.rs Outdated
Comment thread bin/ntx-builder/src/actor/mod.rs Outdated
@Mirko-von-Leipzig Mirko-von-Leipzig merged commit 0f17cc2 into next Jun 13, 2026
23 checks passed
@Mirko-von-Leipzig Mirko-von-Leipzig deleted the santiagopittella-in-memory-accounts branch June 13, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network tx builder: avoid fetching account from store

2 participants