fix(overlay): remove dead full-page CTAs from team + match overlays#290
Merged
Conversation
Tim 2026-06-05: the bracket-picker popups for teams and matches were
advertising full pages ("Full page →", "View match preview", "Open
full team page →", "Open full preview (Predict / H2H / Form / Lineup /
Stats) →") that don't exist yet as publishable surfaces. Users
clicking those landed on stub routes / 404-ish content, so Tim asked
to strip every one of them. The overlays themselves ARE the team /
match preview surface for now.
MatchOverlay:
* drop the header "Full page →" Link
* drop the footer "Open full preview (...)" Link
* drop the now-unused `Link` import + `fullPageHref` variable
TeamOverlay:
* drop the header "Full page →" Link
* drop the "View match preview" button under Next Match
(the fixture rows below still open the MatchOverlay, so navigation
between team + match overlays continues to work)
* drop the footer "Open full team page →" Link
`Link` stays imported in TeamOverlay for the team-not-found fallback
that links back to /world-cup-2026.
Signed-off-by: Tim Thomas <0800tim@gmail.com>
Auto-triage: GREEN — auto-triage clearRisk score: 0/100
No flags raised by the automated scanners. A human reviewer will still take a look. Labels applied: Posted by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tim 2026-06-05: the team + match popups on the bracket picker were advertising "Full page →", "View match preview", "Open full team page →" and "Open full preview (Predict / H2H / Form / Lineup / Stats) →" CTAs that point at routes we haven't built yet. Removed all five so the overlays only show what they can actually deliver. Fixture-row clicks inside TeamOverlay still open the MatchOverlay (same kind of popup, not a route) so navigation between the two overlays is preserved.
Same behaviour applies to the "upcoming matches" tap-target since that opens the same MatchOverlay component.