feat(nav): add 'The Bet' to desktop top nav + drawer#284
Merged
Conversation
After Pools in both surfaces, so the headline-grabbing NZ$1.5M
house wager is one click away on every page. New HouseStackIcon
glyph (house perched on a stack of coins) for the entry.
apps/web/components/shell/nav-links.tsx
PRIMARY_DESKTOP: insert The Bet after Pools.
DRAWER_PRIMARY: insert The Bet between Pools and My Profile,
matching Tim's drawer-order spec.
apps/web/components/shell/icons.tsx
HouseStackIcon, lightweight SVG matching the existing 24x24
24px-grid "baseProps" style used by the other shell icons.
Drawer label uses the same i18n key as the desktop entry so a single
'nav.the_bet' string in the locale catalogues covers both. English
fallback is 'The Bet'.
Tim 2026-06-05.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: Tim Thomas <0800tim@gmail.com>
Auto-triage: GREEN — auto-triage clearRisk score: 0/100
No flags raised by the automated scanners. A human reviewer will still take a look. Labels applied: Posted by |
0800tim
added a commit
that referenced
this pull request
Jun 5, 2026
Tim 2026-06-05 caught the dev-only next-intl error: > MISSING_MESSAGE: Could not resolve `nav.the_bet` in messages > for locale `en`. The nav entry was wired in PR #284 against the key `nav.the_bet` but the locale catalogues were never updated. `safeT` catches the miss and renders the literal "The Bet" fallback so the page never broke, but in dev mode next-intl throws and the overlay reports the miss every render. Translation spread: * Romance / Germanic / Slavic / Turkic: literal "the bet" in the target language (La Apuesta, Le Pari, Die Wette, La Scommessa, A Aposta x2, De Weddenschap, Vadet, Veddemålet, Sázka, A Fogadás, Bahis, Oklada x2, Garov). * CJK: ja / ko use a brand transliteration (ザ・ベット, 더 베트); zh-CN uses 豪赌 ("big wager") for punch since literal "the bet" reads flat. * RTL: ar / fa use the language's bet/wager noun (الرهان, شرطبندی). * mi: Te Whakapae (the contest / wager). 22 catalogues updated, every existing key preserved (Python JSON round-trip with ensure_ascii=False so non-Latin scripts stay readable in source). Signed-off-by: Tim Thomas <0800tim@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds The Bet to:
PRIMARY_DESKTOPafter Pools (desktop top bar).DRAWER_PRIMARYbetween Pools and My Profile (app slide-out drawer).New
HouseStackIconglyph (house on a stack of coins, matching the bet's literal subject) wired into the existing 24x24 shell-icon system.Single i18n key
nav.the_betcovers both surfaces; English fallback is "The Bet".🤖 Generated with Claude Code