extract out git+checkout into custom action to avoid duplicating it in all jobs that use linux containers

Author: zmeadows

.clang-tidy

@@ -1,4 +1,7 @@
 Checks: >
+  portability-avoid-pragma-once,
+  bugprone-unchecked-optional-access,
+  hicpp-no-array-decay,
   clang-analyzer-*,
   bugprone-*,
   performance-*,
@@ -14,7 +17,9 @@ Checks: >
   -hicpp-signed-bitwise,
   -modernize-use-trailing-return-type,
   -hicpp-uppercase-literal-suffix,
-  -bugprone-easily-swappable-parameters
+  -bugprone-easily-swappable-parameters,
+  bugprone-unchecked-optional-access,
+  -portability-avoid-pragma-once
 WarningsAsErrors: "*"
-HeaderFilterRegex: "(src|test)/"
+HeaderFilterRegex: "(src)/"
 FormatStyle: none

…s/setup-linux-build-container/action.yml …s/linux-container-build-setup/action.yml.github/actions/setup-linux-build-container/action.yml renamed to .github/actions/linux-container-build-setup/action.yml .github/actions/setup-linux-build-container/action.yml renamed to .github/actions/linux-container-build-setup/action.yml

@@ -96,4 +96,4 @@ runs:
       uses: rui314/setup-mold@v1
       with:
         mold-version: 2.40.4
-        make-default: false
+        make-default: true

.github/workflows/ci-linux.yml

@@ -17,7 +17,7 @@ permissions:
 
 jobs:
   build:
-    name: build ⏵ ${{ matrix.distro.name }} [${{ matrix.compiler }}]
+    name: build / ${{ matrix.distro.name }} / ${{ matrix.compiler }}
     runs-on: ubuntu-latest
     timeout-minutes: 45
 
@@ -39,18 +39,23 @@ jobs:
       CMAKE_BUILD_PARALLEL_LEVEL: 4
 
     steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
+      - name: Install Git
+        shell: bash
+        run: |
+          set -euxo pipefail
+          export DEBIAN_FRONTEND=noninteractive
+          apt-get -o Acquire::Retries=3 update
+          apt-get -o Dpkg::Use-Pty=0 install -y --no-install-recommends git ca-certificates
+          git config --global --add safe.directory "$GITHUB_WORKSPACE"
 
-      - uses: ./.github/actions/setup-linux-build-container
+      - uses: actions/checkout@v4
+
+      - uses: ./.github/actions/linux-container-build-setup
         with:
           compiler: ${{ matrix.compiler }}
           update_cmake: ${{ matrix.distro.needs_cmake }}
 
       - name: Configure
-        shell: bash
         run: cmake --preset ci
 
       - name: Build

.github/workflows/ci-macos.yml

@@ -17,7 +17,7 @@ permissions:
 
 jobs:
   build:
-    name: build ⏵ ${{ matrix.os }} [apple-clang]
+    name: build / ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     timeout-minutes: 45
 

.github/workflows/code-quality.yml

@@ -25,14 +25,15 @@ jobs:
       - uses: actions/setup-python@v5
         with:
           python-version: "3.x"
+
       - name: Install pinned clang-format
         run: |
           python -m pip install --upgrade pip
           python -m pip install "clang-format==${CF_VERSION}"
           clang-format --version
 
       # Check formatting ONLY for C/C++ files under top-level src/
-      - name: Check formatting (src/* only)
+      - name: Run clang-format # src/* only
         shell: bash
         run: |
           git -c core.quotePath=false ls-files -z -- 'src' \
@@ -48,32 +49,37 @@ jobs:
       image: ubuntu:24.04
 
     steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
+      - name: Install Git
+        shell: bash
+        run: |
+          set -euxo pipefail
+          export DEBIAN_FRONTEND=noninteractive
+          apt-get -o Acquire::Retries=3 update
+          apt-get -o Dpkg::Use-Pty=0 install -y --no-install-recommends git ca-certificates
+          git config --global --add safe.directory "$GITHUB_WORKSPACE"
 
-      - uses: ./.github/actions/setup-linux-build-container
+      - uses: actions/checkout@v4
+
+      - uses: ./.github/actions/linux-container-build-setup
 
       - uses: actions/setup-python@v5
         with:
           python-version: "3.x"
+
       - name: Install pinned clang-tidy
         run: |
           python -m pip install "clang-tidy==${CT_VERSION}"
           clang-tidy --version
 
-      - name: Configure (dev preset -> compile_commands.json in build/dev/)
+      - name: Configure # dev preset -> compile_commands.json in build/dev/
         run: cmake --preset dev
 
       # Run clang-tidy ONLY for C/C++ sources under top-level src/.
       # Header filter also restricted to src/ to avoid build-tree deps.
-      - name: Run clang-tidy (src/* only)
+      - name: Run clang-tidy # src/* only
         shell: bash
         run: |
-          git -c core.quotePath=false ls-files -z -- 'src' \
-            | grep -z -E '\.(c|cc|cpp|cxx|m|mm)$' \
-            | xargs -0 -r -n1 -P"$(nproc)" \
-              clang-tidy -p build/dev \
-                --header-filter='(^|.*/)(src)/' \
-                --warnings-as-errors='*' --
+          git -c safe.directory="$GITHUB_WORKSPACE" -c core.quotePath=false \
+            ls-files -z -- 'src' -- '*.c' '*.cc' '*.cpp' '*.cxx' '*.m' '*.mm' \
+          | xargs -0 -r -n32 -P"$(nproc)" \
+              clang-tidy -p build/dev --config-file=.clang-tidy -quiet

CMakePresets.json

@@ -40,33 +40,16 @@
         "CMAKE_BUILD_TYPE": "RelWithDebInfo",
         "CMAKE_EXPORT_COMPILE_COMMANDS": true,
         "LLDBG_WITH_IMGUI_DEMO": true,
-        "LLDBG_WARN_AS_ERRORS": false
-      }
-    },
-
-    {
-      "name": "dev-tidy",
-      "inherits": "dev",
-      "cacheVariables": {
-        "CMAKE_CXX_CLANG_TIDY": "clang-tidy;-p=${sourceDir}",
-        "CMAKE_EXPOSE_COMPILE_COMMANDS": true
+        "LLDBG_WARN_AS_ERRORS": false,
+        "CMAKE_INTERPROCEDURAL_OPTIMIZATION": false
       }
     },
 
     {
       "name": "ci",
       "displayName": "CI",
       "description": "Non-interactive CI build; export compile_commands; warnings-as-errors.",
-      "inherits": ["ninja-base"],
-      "cacheVariables": {
-        "CMAKE_BUILD_TYPE": "RelWithDebInfo",
-        "CMAKE_EXPORT_COMPILE_COMMANDS": true,
-        "LLDBG_WITH_IMGUI_DEMO": false,
-        "LLDBG_WARN_AS_ERRORS": false,
-        "CMAKE_INTERPROCEDURAL_OPTIMIZATION": false,
-        "CMAKE_C_FLAGS_RELWITHDEBINFO": "-O0 -g0",
-        "CMAKE_CXX_FLAGS_RELWITHDEBINFO": "-O0 -g0"
-      }
+      "inherits": ["dev"]
     }
   ],
 

cmake/LLDBGDeps.cmake

@@ -301,4 +301,5 @@ get_target_property(_LLDBG_LLDB_INCS lldbg::lldb INTERFACE_INCLUDE_DIRECTORIES)
 get_target_property(_LLDBG_LLDB_LIBS lldbg::lldb INTERFACE_LINK_LIBRARIES)
 message(STATUS "LLDBG: Using lldbg::lldb")
 message(STATUS "       includes: ${_LLDBG_LLDB_INCS}")
-message(STATUS "       link libs: ${_LLDBG_LLDB_LIBS}")
+message(STATUS "       link libs: ${_LLDBG_LLDB_LIBS}")
+