From 4673f2266f205ab2e5272789f2489161a488e012 Mon Sep 17 00:00:00 2001 From: Jose Date: Thu, 22 Jan 2026 10:27:26 +0100 Subject: [PATCH 1/2] Fix sn.exe not found in PATH during strong name signing Add the .NET Framework SDK tools directory to PATH in the build-dotnet-packages workflow to ensure sn.exe is available for strong name signing. Co-Authored-By: Claude Opus 4.5 --- .github/workflows/build-dotnet-packages.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/build-dotnet-packages.yml b/.github/workflows/build-dotnet-packages.yml index dd0904d9835..09a7525e42e 100644 --- a/.github/workflows/build-dotnet-packages.yml +++ b/.github/workflows/build-dotnet-packages.yml @@ -126,6 +126,15 @@ jobs: # Set environment variables for the build echo "PUBLIC_KEYFILE=${{ github.workspace }}\csharp\msbuild\ice-release-pub-key.snk" >> $env:GITHUB_ENV echo "KEYFILE=${{ github.workspace }}\csharp\msbuild\ice-release-key.snk" >> $env:GITHUB_ENV + + # Add the .NET Framework SDK tools directory to PATH for sn.exe (strong name tool) + $sdkToolsPath = "${env:ProgramFiles(x86)}\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8.1 Tools" + if (Test-Path $sdkToolsPath) { + Write-Host "Adding $sdkToolsPath to PATH" + echo $sdkToolsPath >> $env:GITHUB_PATH + } else { + Write-Host "Warning: .NET Framework SDK tools path not found at $sdkToolsPath" + } } else { Write-Host "Strong name signing keys not configured - assemblies will not be signed" } From b9951bc5841a2e20a9fb6c62448c0d6640baa8b6 Mon Sep 17 00:00:00 2001 From: Jose Date: Thu, 22 Jan 2026 18:15:17 +0100 Subject: [PATCH 2/2] Fix upload path --- .github/workflows/build-dotnet-packages.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-dotnet-packages.yml b/.github/workflows/build-dotnet-packages.yml index 09a7525e42e..2b7790f4201 100644 --- a/.github/workflows/build-dotnet-packages.yml +++ b/.github/workflows/build-dotnet-packages.yml @@ -181,5 +181,5 @@ jobs: with: name: dotnet-nuget-packages path: | - csharp/msbuild/zeroc.ice.net/*.nupkg - csharp/msbuild/zeroc.ice.net/*.snupkg + csharp/msbuild/*.nupkg + csharp/msbuild/*.snupkg