Merge pull request #126 from xendit/invoice-paramsUpdate

invoice-paramsUpdate

Author: xen-HendryZheng

examples/with_async/card.js

@@ -18,7 +18,7 @@ const authID = '5e0461a96113354249aab7ee';
       externalID: Date.now().toString(), // use your system's ID of the transaction
       capture: false,
       metadata: {
-        test: "data",
+        test: `data`,
       },
     });
     console.log('charge created:', charge); // eslint-disable-line no-console

integration_test/va.test.js

@@ -2,20 +2,26 @@ const x = require('./xendit.test');
 
 const VirtualAcc = x.VirtualAcc;
 const va = new VirtualAcc({});
-
-module.exports = function() {
+function sleepFor(sleepDuration){
+  var now = new Date().getTime();
+  while(new Date().getTime() < now + sleepDuration){ /* Do nothing */ }
+}
+module.exports = function () {
   return va
     .getVABanks()
     .then(banks => {
       return va.createFixedVA({
-        externalID: new Date().toLocaleString(),
+        externalID: 'VA-' + new Date().toLocaleString(),
         bankCode: banks[0].code,
         name: 'Stanley Nguyen',
         isClosed: true,
         expectedAmt: 10000,
       });
     })
-    .then(({ id }) => va.getFixedVA({ id }))
+    .then(({ id }) => {
+      sleepFor(3000);
+      return va.getFixedVA({ id })
+    })
     .then(({ id }) => {
       return va.updateFixedVA({
         id,

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "xendit-node",
-  "version": "1.19.1",
+  "version": "1.19.2",
   "description": "NodeJS client for Xendit API",
   "main": "index.js",
   "types": "index.d.ts",

package.json

@@ -23,6 +23,11 @@ export = class Invoice {
     currency?: string;
     midLabel?: string;
     forUserID?: string;
+    reminderTimeUnit?: string;
+    reminderTime?: number;
+    locale?: string;
+    shouldAuthenticateCreditCard?: boolean;
+    withFeeRule?: string;
   }): Promise<object>;
   getInvoice(data: { invoiceID: string; forUserID?: string }): Promise<object>;
   expireInvoice(data: {

src/invoice/invoice.d.ts

@@ -37,6 +37,10 @@ Invoice.prototype.createInvoice = function(data) {
       headers['for-user-id'] = data.forUserID;
     }
 
+    if (data && data.withFeeRule) {
+      headers['with-fee-rule'] = data.withFeeRule;
+    }
+
     fetchWithHTTPErr(`${this.API_ENDPOINT}/v2/invoices`, {
       method: 'POST',
       headers,
@@ -58,6 +62,10 @@ Invoice.prototype.createInvoice = function(data) {
         customer_notification_preference: data.customerNotificationPreference,
         items: data.items,
         fees: data.fees,
+        reminder_time_unit: data.reminderTimeUnit,
+        reminder_time: data.reminderTime,
+        locale: data.locale,
+        should_authenticate_credit_card: data.shouldAuthenticateCreditCard,
       }),
     })
       .then(resolve)