diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 966459b..52b03c4 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -33,6 +33,15 @@ body: validations: required: true + - type: textarea + id: description + attributes: + label: Description of the problem + description: | + Describe as exactly as possible what is not working. + validations: + required: true + - type: textarea id: steps-to-reproduce attributes: @@ -47,20 +56,6 @@ body: validations: required: true - - type: textarea - id: expected-behavior - attributes: - label: Expected behavior - description: | - Tell us what you expect to happen. - - - type: textarea - id: actual-behavior - attributes: - label: Actual behavior - description: | - Tell us what happens with the steps given above. - - type: textarea id: additional-information attributes: diff --git a/CHANGELOG.md b/CHANGELOG.md index 547b515..50c843a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,6 @@ +# 1.2.2 +* [Browser] Improve SHM configuration + # 1.2.1 * Migrated deployment to _Sonatype Maven Central Portal_ [#155](https://github.com/xdev-software/standard-maven-template/issues/155) * Updated dependencies diff --git a/pom.xml b/pom.xml index a50781e..304b3e6 100644 --- a/pom.xml +++ b/pom.xml @@ -45,7 +45,7 @@ com.puppycrawl.tools checkstyle - 10.23.1 + 10.25.0 @@ -82,12 +82,12 @@ net.sourceforge.pmd pmd-core - 7.13.0 + 7.14.0 net.sourceforge.pmd pmd-java - 7.13.0 + 7.14.0 diff --git a/testcontainers-selenium-demo/pom.xml b/testcontainers-selenium-demo/pom.xml index c5d5f0e..2e494fb 100644 --- a/testcontainers-selenium-demo/pom.xml +++ b/testcontainers-selenium-demo/pom.xml @@ -34,7 +34,7 @@ org.seleniumhq.selenium selenium-dependencies-bom - 4.32.0 + 4.33.0 pom import diff --git a/testcontainers-selenium/pom.xml b/testcontainers-selenium/pom.xml index 0f81d95..832c7b4 100644 --- a/testcontainers-selenium/pom.xml +++ b/testcontainers-selenium/pom.xml @@ -56,7 +56,7 @@ org.testcontainers testcontainers - 1.21.0 + 1.21.1 @@ -68,7 +68,7 @@ software.xdev testcontainers-junit4-mock - 1.0.1 + 1.0.2 @@ -82,7 +82,7 @@ org.seleniumhq.selenium selenium-api - 4.32.0 + 4.33.0 provided @@ -90,7 +90,7 @@ org.junit.jupiter junit-jupiter - 5.12.2 + 5.13.0 test @@ -102,7 +102,7 @@ org.seleniumhq.selenium selenium-remote-driver - 4.32.0 + 4.33.0 test @@ -120,13 +120,13 @@ org.seleniumhq.selenium selenium-support - 4.32.0 + 4.33.0 test org.seleniumhq.selenium selenium-firefox-driver - 4.32.0 + 4.33.0 test @@ -139,7 +139,7 @@ org.seleniumhq.selenium selenium-chrome-driver - 4.32.0 + 4.33.0 test @@ -326,7 +326,7 @@ com.puppycrawl.tools checkstyle - 10.23.1 + 10.25.0 @@ -363,12 +363,12 @@ net.sourceforge.pmd pmd-core - 7.13.0 + 7.14.0 net.sourceforge.pmd pmd-java - 7.13.0 + 7.14.0 diff --git a/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/BrowserWebDriverContainer.java b/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/BrowserWebDriverContainer.java index 6cd67a9..9d59c06 100644 --- a/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/BrowserWebDriverContainer.java +++ b/testcontainers-selenium/src/main/java/software/xdev/testcontainers/selenium/containers/browser/BrowserWebDriverContainer.java @@ -89,6 +89,8 @@ public class BrowserWebDriverContainer osName.startsWith("Windows")) - .orElse(false)) + if(this.shouldDirectMountShm()) { - this.withSharedMemorySize(512 * FileUtils.ONE_MB); + this.getBinds().add(new Bind("/dev/shm", new Volume("/dev/shm"), AccessMode.rw)); } else { - this.getBinds().add(new Bind("/dev/shm", new Volume("/dev/shm"), AccessMode.rw)); + this.withSharedMemorySize(512 * FileUtils.ONE_MB); } } } + protected boolean shouldDirectMountShm() + { + return !isCurrentOsWindows(); + } + + protected static boolean isCurrentOsWindows() + { + if(currentOsWindows == null) + { + currentOsWindows = Optional.ofNullable(System.getProperty("os.name")) + .map(osName -> osName.startsWith("Windows")) + .orElse(false); + } + return !currentOsWindows; + } + protected void configureVNC() { if(this.disableVNC)