Skip to content

Commit 6ed5c8c

Browse files
authored
Merge pull request #71 from wpgaurav/claude/add-pros-cons-icons-d7xu4
Replace SVG icons with Unicode characters in pros-cons block
2 parents 9d2f51e + 395beec commit 6ed5c8c

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

acf-blocks.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* Plugin Name: ACF Blocks
44
* Plugin URI: https://github.com/wpgaurav/acf-blocks-plugin
55
* Description: A collection of ACF Pro blocks for the WordPress block editor with automatic field group registration.
6-
* Version: 2.4.0
6+
* Version: 2.4.1
77
* Requires at least: 6.0
88
* Requires PHP: 7.4
99
* Author: Gaurav Tiwari
@@ -19,7 +19,7 @@
1919
}
2020

2121
// Plugin constants
22-
define( 'ACF_BLOCKS_VERSION', '2.3.1' );
22+
define( 'ACF_BLOCKS_VERSION', '2.4.1' );
2323
define( 'ACF_BLOCKS_PLUGIN_DIR', plugin_dir_path( __FILE__ ) );
2424
define( 'ACF_BLOCKS_PLUGIN_URL', plugin_dir_url( __FILE__ ) );
2525
define( 'ACF_BLOCKS_PLUGIN_FILE', __FILE__ );

blocks/pros-cons/pros-cons.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

blocks/pros-cons/pros-cons.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ function acf_pros_cons_process_list($html, $type = 'positive') {
1616
return '';
1717
}
1818

19-
// SVG icons (inline for performance - no extra HTTP requests)
20-
$check_icon = '<span class="acf-pros-cons__icon" aria-hidden="true"><svg width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="3" stroke-linecap="round" stroke-linejoin="round"><polyline points="20 6 9 17 4 12"></polyline></svg></span>';
21-
$x_icon = '<span class="acf-pros-cons__icon" aria-hidden="true"><svg width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="3" stroke-linecap="round" stroke-linejoin="round"><line x1="18" y1="6" x2="6" y2="18"></line><line x1="6" y1="6" x2="18" y2="18"></line></svg></span>';
19+
// Unicode icons for pros/cons
20+
$check_icon = '<span class="acf-pros-cons__icon" aria-hidden="true">&#x2713;</span>';
21+
$x_icon = '<span class="acf-pros-cons__icon" aria-hidden="true">&#x2717;</span>';
2222

2323
$icon = ($type === 'positive') ? $check_icon : $x_icon;
2424

0 commit comments

Comments
 (0)