A warning was added to drop a signature from aggregation if the set doesn't match, but ideally we could more gracefully ensure consensus by capturing all signatures in more flexible fashion.
During the Manager Set rotation, managers might end up signing a transaction with a different ManagerSetIndex, because each manager independently reads this value from the contract. Maybe it was discussed already, in that case feel free to ignore.
We can add check like this in storeSignature
if aggTx != nil {
if aggTx.ManagerSetIndex != sig.ManagerSetIndex {
error ...
}
}
Originally posted by @bemic in #4816 (review)
A warning was added to drop a signature from aggregation if the set doesn't match, but ideally we could more gracefully ensure consensus by capturing all signatures in more flexible fashion.
During the Manager Set rotation, managers might end up signing a transaction with a different ManagerSetIndex, because each manager independently reads this value from the contract. Maybe it was discussed already, in that case feel free to ignore.
We can add check like this in
storeSignatureOriginally posted by @bemic in #4816 (review)