Skip to content

Commit ffcbb0c

Browse files
authored
ci: improve release workflows and update node engine requirement (#200)
## Summary Two small improvements to the CI/CD setup: - **`ci: improve release workflows and permissions`** — tightens permission scopes in `release-tag.yml` (`contents: write` comment clarified, `persist-credentials: true` enabled so tag pushes work), and adds a trailing newline to the PR-body `BODY` string in `release-pr.yml` to fix formatting in generated release PRs. - **`fix(package): update node engine requirement to >=24`** — changes the engines constraint from the exact string `"24"` to `">=24"` so the project continues to work with future Node.js major releases without requiring a version bump to `package.json`. ## Changed files | File | Change | |------|--------| | `.github/workflows/release-pr.yml` | Add trailing `\n` to `BODY`/`TRUNCATED` strings | | `.github/workflows/release-tag.yml` | Clarify `contents: write` comment; enable `persist-credentials` | | `package.json` | Engine constraint `"24"` -> `">=24"` | ## Type of change - [x] CI/CD or workflow improvement - [x] Bug fix (non-breaking) ## Pre-flight checklist - [x] Commits follow Conventional Commits - [x] No breaking changes - [x] No new dependencies introduced
2 parents 3edc0c2 + b66e004 commit ffcbb0c

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/release-pr.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ jobs:
111111
BODY="${BODY}---\n\n"
112112
BODY="${BODY}> Merging this PR will:\n"
113113
BODY="${BODY}> - Deploy to \`wolfstar.rocks\` via Netlify\n"
114-
BODY="${BODY}> - Create a \`${NEXT_VERSION}\` tag and GitHub Release"
114+
BODY="${BODY}> - Create a \`${NEXT_VERSION}\` tag and GitHub Release\n"
115115
116116
# Write body to file, truncating if needed (GitHub limits PR body to 65536 chars)
117117
echo -e "$BODY" > /tmp/pr-body.md
@@ -125,7 +125,7 @@ jobs:
125125
TRUNCATED="${TRUNCATED}---\n\n"
126126
TRUNCATED="${TRUNCATED}> Merging this PR will:\n"
127127
TRUNCATED="${TRUNCATED}> - Deploy to \`wolfstar.rocks\` via Netlify\n"
128-
TRUNCATED="${TRUNCATED}> - Create a \`${NEXT_VERSION}\` tag and GitHub Release"
128+
TRUNCATED="${TRUNCATED}> - Create a \`${NEXT_VERSION}\` tag and GitHub Release\n"
129129
echo -e "$TRUNCATED" > /tmp/pr-body.md
130130
fi
131131

.github/workflows/release-tag.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
runs-on: ubuntu-latest
1818
if: github.repository == 'wolfstar-project/wolfstar.rocks'
1919
permissions:
20-
contents: write # push tags and create releases
20+
contents: write # create release tags and GitHub releases
2121
outputs:
2222
version: ${{ steps.version.outputs.next }}
2323
skipped: ${{ steps.check.outputs.skip }}
@@ -26,7 +26,7 @@ jobs:
2626
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
2727
with:
2828
fetch-depth: 0
29-
persist-credentials: false
29+
persist-credentials: true
3030

3131
- uses: voidzero-dev/setup-vp@ca1c46663915d6c1042ae23bd39ab85718bfb0fa # v1.10.0
3232
with:

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@
148148
}
149149
},
150150
"engines": {
151-
"node": "24",
151+
"node": ">=24",
152152
"pnpm": ">=10"
153153
},
154154
"packageManager": "pnpm@11.1.0"

0 commit comments

Comments
 (0)