[Bug]: Use of `Sha256` instead of `wc_Sha256` in sign/verify

[andrade]

Contact Details

No response

Version

5.6.6-1.3build1 (it's libwolfssl-dev from Ubuntu 24.04 repositories)

Description

wolfSSL installed from repositories in Ubuntu 24.04.

The issue is when running sign/verify examples at signature/rsa_buffer/. Running make I get an error:

$ make sign
gcc -o sign sign.c -Wall -I/usr/local/include -Os -L/usr/local/lib -lm -lwolfssl
sign.c: In function ‘main’:
sign.c:77:5: error: unknown type name ‘Sha256’; did you mean ‘wc_Sha256’?
   77 |     Sha256         sha256;
      |     ^~~~~~
      |     wc_Sha256
sign.c:78:5: error: unknown type name ‘Sha256’; did you mean ‘wc_Sha256’?
   78 |     Sha256*        pSha256 = NULL;
      |     ^~~~~~
      |     wc_Sha256

I can compile $make sign and $ make verify successfully, and run both examples, by replacing Sha256 by wc_Sha256 in sign.c and verify.c.

---

Note the same issue may be present in a different file but I didn't try running that one:

$ pwd
/home/daniel/tmp/tmpdir/wolfssl-examples

$ grep -rn " Sha256"
signature/rsa_vfy_only/verify.c:120:    Sha256         sha256;
signature/rsa_vfy_only/verify.c:121:    Sha256*        pSha256 = NULL;
(...)

Reproduction steps

1. Setup:

$ mkdir tmpdir
$ cd tmpdir/
$ git clone https://github.com/wolfSSL/wolfssl-examples/
$ cd wolfssl-examples/signature/rsa_buffer/

2. Compilation error:

$ make sign
$ make verify

3. Fixing, then compile and run:

$ sed -i 's/ Sha256/wc_Sha256/g' sign.c verify.c
$ make sign
$ make verify
$ ./verify
$ ./sign "foo"

Relevant log output

[embhorn]

Hi @andrade

Thanks for contacting wolfSSL Support. We'll get this issue resolved shortly. We did update the default to disable the older naming style. I was able to reproduce this issue.

Can you tell us a bit about your project using wolfSSL?

Thanks,
Eric - wolfSSL Support

[BridgerVoss]

Hi andrade,
This issue should be fixed now. Here is the PR #511

Thanks,
Bridger

[andrade]

Thank you, it's working now for me.

@dgarske I'm using wolfSSL in an academic project involving trusted execution environments. (I've been previously using the OpenSSL libraries but I wanted to try wolfSSL since it also works inside SGX.)

I got stuck trying to verify a signature which is why I was looking at the examples. (Still stuck, my hello-world code works with the original keying material I copied from this repository, but not with the one I generated using OpenSSL. I'm getting a segfault in wc_RsaSSL_VerifyInline. 😕)

—Daniel

[dgarske]

Thank you, it's working now for me.

@dgarske I'm using wolfSSL in an academic project involving trusted execution environments. (I've been previously using the OpenSSL libraries but I wanted to try wolfSSL since it also works inside SGX.)

I got stuck trying to verify a signature which is why I was looking at the examples. (Still stuck, my hello-world code works with the original keying material I copied from this repository, but not with the one I generated using OpenSSL. I'm getting a segfault in wc_RsaSSL_VerifyInline. 😕)

—Daniel

Hi @andrade ,

Your issue is static const unsigned char signature[] = {. You cannot pass a const to wc_RsaSSL_VerifyInline (https://github.com/andrade/hellocrypto/blob/master/km_mine_4096.h#L23C28-L23C37), which is an inline operation and will attempt to modify the buffer.

rsa_check.c:100:29: warning: passing 'const unsigned char[512]' to parameter of type 'byte *' (aka 'unsigned char *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
  100 |         r = wc_RsaSSL_VerifyInline(signature, sizeof(signature), &decoSig, &rsaKey);
      |                                    ^~~~~~~~~
/usr/local/include/wolfssl/wolfcrypt/rsa.h:340:47: note: passing argument to parameter 'in' here
  340 | WOLFSSL_API int  wc_RsaSSL_VerifyInline(byte* in, word32 inLen, byte** out,
      |                                               ^

Thanks,
David Garske, wolfSSL