From e7c21da55e49d9d24697cb05f2102bf017cdf72f Mon Sep 17 00:00:00 2001 From: harry Date: Thu, 19 Nov 2026 18:05:37 +0900 Subject: [PATCH] docs: D75, the three decisions before 1.0, and the notices in the crates Issue #165 put three choices to the maintainer, who left them to their agent. D75 records them: the shared library's name will carry the crate's major version (its own PR follows); `emberwave-wgpu` will be split out of `emberwave-core` so that the core has no wgpu type in its API, with the inventory, the six core items the move has to open, the dependents, the tests, the order of the work and the risks (no code moves yet); and THIRD_PARTY_NOTICES.md goes into both crates. The third is done here: the notices are copied next to LICENSE into emberwave-core and emberwave-cli (`cargo package --list` shows them), scripts/check_license_copies.sh, a step of the lint job, keeps the copies equal to the root's, and CONTRIBUTING and D74 say so. They reach crates.io with the next publish, which needs the maintainer's approval. The README's 1.0 checklist says what is decided and still to do. Claude-Session: https://claude.ai/code/session_019fJGoCTvP5e7n599q3ZQ42 --- .github/workflows/ci.yml | 2 ++ ARCHITECTURE.md | 32 +++++++++++++++++- CONTRIBUTING.md | 4 +-- README.ko.md | 2 +- README.md | 2 +- crates/emberwave-cli/THIRD_PARTY_NOTICES.md | 34 ++++++++++++++++++++ crates/emberwave-core/THIRD_PARTY_NOTICES.md | 34 ++++++++++++++++++++ scripts/check_license_copies.sh | 20 ++++++++++++ 8 files changed, 125 insertions(+), 5 deletions(-) create mode 100644 crates/emberwave-cli/THIRD_PARTY_NOTICES.md create mode 100644 crates/emberwave-core/THIRD_PARTY_NOTICES.md create mode 100755 scripts/check_license_copies.sh diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0d5b16d..fe9f3d8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -31,6 +31,8 @@ jobs: rustup default stable - uses: Swatinem/rust-cache@d1527c8f67ef9af357290475d4af4b0fab8f12e0 # v2.9.3 - run: cargo fmt --all --check + # The crates carry copies of LICENSE and THIRD_PARTY_NOTICES.md (decision D75). + - run: scripts/check_license_copies.sh - run: cargo clippy --workspace --all-targets -- -D warnings # The parser and the CPU decoder alone, which emberwave-core is without # its default `gpu` feature. diff --git a/ARCHITECTURE.md b/ARCHITECTURE.md index c717771..fb93612 100644 --- a/ARCHITECTURE.md +++ b/ARCHITECTURE.md @@ -1896,7 +1896,37 @@ The last frame's detail, always, gains everything on a still picture and loses u - The upload uses a token that the maintainer made on crates.io with the scopes `publish-new` and `publish-update` and a 30-day expiry (to about 2026-12-04), stored by their own `cargo login`. It is never read, printed or passed on. - The approval covered the first publish. A later version needs the maintainer's approval again, or Trusted Publishing: in each crate's settings on crates.io, GitHub with owner `with-developer`, repository `emberwave` and workflow `release.yml`, after which the release workflow could publish without a long-lived token. -**Not done.** `THIRD_PARTY_NOTICES.md` is not in the packages: `cargo package --list` shows `LICENSE` and no notices file, where the release archives carry both (D51). Whether a crate has to carry PyroWave's notice is the maintainer's to judge, not settled here. Trusted Publishing is not set up. +**Not done.** `THIRD_PARTY_NOTICES.md` was not in the packages: `cargo package --list` showed `LICENSE` and no notices file, where the release archives carry both (D51). D75 copies it into both crates; it reaches crates.io with the next publish. Trusted Publishing is not set up. **Consequence.** A published version cannot be taken back, only yanked, so a release that publishes is a step to confirm. The workspace version, `EMBERWAVE_VERSION` and the crates' dependency on `emberwave-core` move together (D69). +### 2026-11-19 — D75: Before 1.0: the library's name, wgpu in the Rust API, the notices in the crates + +**Context.** Issue #165 put three choices to the maintainer, with the evidence. On 2026-11-19 they left them to the maintainer's agent ("알아서 해라"), as with the earlier pending calls. Publishing, a release and a new crates.io name stay the maintainer's. + +**Decisions.** +1. **The shared library's name carries the major version.** From the crate's major version, 0 now and 1 at 1.0.0, so that it starts to mean the ABI at 1.0 (D69): Linux soname `libemberwave_ffi.so.MAJOR`; macOS install name `@rpath/libemberwave_ffi.MAJOR.dylib` with compatibility version `MAJOR.0.0` and the crate's version as the current one; Windows keeps `emberwave_ffi.dll`. Release archives hold the versioned file and the unversioned name as a link, so that a program linked before keeps finding its file (option B of #165). Not chosen: leaving the names unversioned until the first break (the unversioned name would then mean "version 1" for ever, and the first break would need a new name beside it, with clients linked), and the macOS compatibility version alone (nothing for Linux). Done in its own PR. +2. **A crate without wgpu in its API: split `emberwave-wgpu` out of `emberwave-core`** (option 3 of #165). Design below; the move is a later series of PRs, one a night, and none of it is done by this decision. The new crate is `publish = false` until the maintainer decides its name for crates.io. Not chosen: keeping the re-export and letting emberwave's major follow wgpu's (option 1), which costs nothing now but breaks the Rust API's promise at every wgpu major, and hiding wgpu behind types of emberwave's own (option 2), a rewrite of the 26 items without a gain over the split. +3. **`THIRD_PARTY_NOTICES.md` goes into both crates**, next to `LICENSE`, as a copy that `scripts/check_license_copies.sh` keeps equal to the root's. A notice that ships when it did not have to is harmless; one that is missing is the risk. It takes effect with the next publish, which needs the maintainer's approval (D74). + +**What the data says about the split** (measured on 2026-11-19 at `a1c456f`). +- The boundary exists: `emberwave-core`'s `gpu` feature already builds the parser, the CPU decoder and the CPU encoder without wgpu, and CI lints that (`clippy -p emberwave-core --no-default-features`). The feature's module, `src/gpu`, is 10,325 lines (the Rust of the decoder, the encoder, the context, the layout, the resources and the pipelines, and 13 WGSL shaders); the rest of the core, `bitstream`, `cpu`, `color` and `encode`, is 6,934 lines and has nothing from `gpu`, apart from two doc references in `cpu`. +- **What stays in `emberwave-core`**: the bitstream (header, layout, packets, `FrameAssembler`, `FrameView`, PWV1 files), the CPU reference decoder with `Concealer`, the colour conversions, and the CPU encoder with `EncodeError` and `Signalling`. Everything a program needs to parse, assemble, decode or encode a frame on the CPU; no wgpu in its dependencies or its public API. +- **What moves to `emberwave-wgpu`**: all of `src/gpu` (`GpuContext`, `GpuOptions`, the GPU `Decoder` and `Encoder`, `GpuError`, `TexturePicture`, `SubmissionHooks`, the layout and the shaders), and the `pub use wgpu`. These are the 25 public fields, functions and constants that take or return wgpu's types (setup 3, a context from the client's objects 3, reaching wgpu's objects 5, decoding into the client's textures and buffers 14), the re-export, the hooks trait's three methods and `TexturePicture`'s variants. The wgpu-free calls of the GPU decoder and encoder, to and from planes in CPU memory, are methods of the same types, so they move with them: a Rust program that wants GPU decoding follows wgpu's majors, and the core's promise covers what is left, the parser, the CPU codecs and the colour code. +- **What the move has to open in the core**: the GPU encoder and decoder use six items of the core that are `pub(crate)` today (found by searching the GPU module for the paths it names; the compiler will show any more in the first step), with the modules `encode::{fdwt, quant, rate}` that hold them: `encode::fdwt::sample_level`, `encode::pristine_blocks`, `encode::rate::BlockCost`, `encode::quant::{BandQuant, DROP_STEPS}` and `color::check_rgb`, beside the `doc(hidden)` ones that are public already (`cpu::dequant`, `cpu::idwt`, parts of `color`). They become `#[doc(hidden)] pub` with the existing sentence that such items are for emberwave's own crates and may change in any release, and `emberwave-wgpu` depends on `emberwave-core` with `=` the same version. This is the split's cost: a hidden surface between two crates of one repository. +- **Dependents**: `emberwave-cli` (26 lines naming `gpu::`), `emberwave-ffi` (138 lines, and the C API does not change), `emberwave-web` (24) and `emberwave-stream`'s host (a private repository pinned to a commit: four imports, `emberwave_core::gpu::{Encoder, GpuContext, GpuError, GpuOptions}`, and none of wgpu's types). Their paths change; no behaviour does. +- **Tests**: `tests/gpu.rs` (2,219 lines), `gpu_encoder.rs` (1,192), `gpu_hooks.rs` (101) and `shaders.rs` (241, with the `naga` dev-dependency) move; `common/mod.rs` (289 lines, shared) is needed by both crates and is copied or turned into a small test-support module that both include; `vectors.rs`, `robustness.rs` and `encoder.rs` (603) stay. +- **The release gains a step.** `emberwave-cli` depends on `emberwave-wgpu`, so a published `emberwave-cli` needs `emberwave-wgpu` published first (core, then wgpu, then cli). The new name on crates.io is therefore needed before the next cli release; that is the maintainer's call, and until it is made the repository's crates are published as they are (0.18.1 of core with its `gpu` feature stays as it is, and 0.x allows the break). +- **Versions.** `emberwave-core` follows the repository's version and, from 1.0, the promise. `emberwave-wgpu` has its own version, which takes a new major version when a wgpu major changes the types it shows; it depends on `wgpu` with the major it was built for. + +**The order of the work**, each a PR that leaves `main` green. +1. Open the six items in the core (`#[doc(hidden)] pub`, the sentence in `lib.rs`), with nothing else changed. +2. The move, in one PR, because the dependents break the moment `gpu` leaves: `git mv` `src/gpu`, the GPU tests and the shaders into `crates/emberwave-wgpu`, the crate's manifest (`publish = false`, the `=` dependency on the core, `wgpu`, `pollster`, `bytemuck`), the core without its `gpu` feature and its wgpu dependencies, the dependents' paths in `emberwave-cli`, `emberwave-ffi` and `emberwave-web`, the CI jobs and scripts that name the moved tests (`cargo test -p emberwave-core --test gpu`, `scripts/soak.sh`), and the release workflow's packaging. +3. Docs: the README, `ARCHITECTURE.md`, `CONTRIBUTING.md`'s table of tests, the C API README's notes on the crates, the changelog. +4. `emberwave-stream` moves to the new commit and path. +5. The release workflow publishes core, wgpu, cli in that order, once the maintainer has taken the name. + +**Risks.** The hidden surface drifts between the two crates; the tests' relative paths to `testdata` stay valid, as the new crate sits at the same depth; rustdoc links from `cpu` to `gpu` become plain text; the move is large (about 14,000 lines) but mechanical, which `git mv` keeps in the history; a published `emberwave-core` 0.18.1 has the `gpu` feature that later versions do not, which no known user has used. + +**Consequence.** The checklist item "stable C and Rust APIs" in the README can close when the library's name carries its version and the split has landed, or earlier, if the maintainer decides to ship 1.0 with option 1's plain statement instead; the data above is what that choice would weigh. No code moves with this entry. + diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index eb3b701..5a2c979 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -73,7 +73,7 @@ After a deliberate change to what the encoder writes, `scripts/gen_encoder_vecto - **No "fix later" comments.** Open an issue instead. - **New dependencies** need a reason in the pull request. - **The C API's structs.** A struct the C API takes or fills in through a pointer starts with `struct_size` (decision D69). A member is added at the end, only, and its zero is its default; the struct's `FIRST_SIZE` stays the size it had before. The calls read and write a struct through `read_struct` and `write_struct`, never by dereferencing the pointer. -- **A release** changes the version in `Cargo.toml` and `EMBERWAVE_VERSION_MAJOR`, `_MINOR`, `_PATCH` and `EMBERWAVE_VERSION` in `crates/emberwave-ffi/src/lib.rs` together, as the build fails otherwise, and regenerates the header. Once its tag's release is out, `cargo publish -p emberwave-core` and then `cargo publish -p emberwave-cli` put the two crates on crates.io; `emberwave-ffi` and `emberwave-web` are not published. `LICENSE` is copied into both crates, so a change to it goes into the copies too. +- **A release** changes the version in `Cargo.toml` and `EMBERWAVE_VERSION_MAJOR`, `_MINOR`, `_PATCH` and `EMBERWAVE_VERSION` in `crates/emberwave-ffi/src/lib.rs` together, as the build fails otherwise, and regenerates the header. Once its tag's release is out, `cargo publish -p emberwave-core` and then `cargo publish -p emberwave-cli` put the two crates on crates.io; `emberwave-ffi` and `emberwave-web` are not published. `LICENSE` and `THIRD_PARTY_NOTICES.md` are copied into both crates, and `scripts/check_license_copies.sh` (a step of the lint job) checks that they are the root's, so a change to either goes into the copies too. ## Commits and pull requests @@ -85,4 +85,4 @@ After a deliberate change to what the encoder writes, `scripts/gen_encoder_vecto ## Licence -emberwave is MIT licensed, and contributions are accepted under the same licence. [`LICENSE`](LICENSE) is the MIT licence alone; PyroWave's licence, and what is in the repository but not covered by the licence, are in [`THIRD_PARTY_NOTICES.md`](THIRD_PARTY_NOTICES.md), which ships in the release archives (decision D51); the crates on crates.io carry `LICENSE` alone. +emberwave is MIT licensed, and contributions are accepted under the same licence. [`LICENSE`](LICENSE) is the MIT licence alone; PyroWave's licence, and what is in the repository but not covered by the licence, are in [`THIRD_PARTY_NOTICES.md`](THIRD_PARTY_NOTICES.md), which ships in the release archives (decision D51) and in the crates on crates.io (D75). diff --git a/README.ko.md b/README.ko.md index be9004c..8d4c495 100644 --- a/README.ko.md +++ b/README.ko.md @@ -155,7 +155,7 @@ iPhone 17의 Safari에서는 [벤치마크 페이지](https://with-developer.git 1.0.0의 날짜는 정하지 않았습니다. 1.0.0은 C·Rust API를 호환되게 유지하겠다는 약속이고, 아래 네 가지가 갖춰지면 태그를 달며, 그 판단은 관리자가 합니다. -- [ ] **안정된 C·Rust API.** 정리된 것: C API가 프로그램을 깨지 않고 늘어나는 규칙(결정 D69), Rust API의 모양(D70), 공유 라이브러리가 헤더의 함수만 내보내는 것(macOS에서 Objective-C 이름 4개만 예외, D73). 남은 것: 라이브러리 이름에 아직 버전이 없고, Rust API의 공개 항목 약 서른 개가 wgpu 타입을 받거나 돌려주므로(결정 D70) wgpu의 새 주 버전이 나오면 깨지며, 클라이언트 자신의 Metal·Vulkan·Direct3D 객체를 받는 호출은 실제로 쓰이기 전까지 잠정입니다. 앞의 두 가지는 [#165](https://github.com/with-developer/emberwave/issues/165)에 질문으로 올려 두었습니다. +- [ ] **안정된 C·Rust API.** 정리된 것: C API가 프로그램을 깨지 않고 늘어나는 규칙(결정 D69), Rust API의 모양(D70), 공유 라이브러리가 헤더의 함수만 내보내는 것(macOS에서 Objective-C 이름 4개만 예외, D73). 정했고 아직 할 일(D75, [#165](https://github.com/with-developer/emberwave/issues/165)): 공유 라이브러리 이름에 주 버전을 넣고, GPU 코드를 `emberwave-wgpu`라는 별도 크레이트로 옮겨 `emberwave-core`의 API에는 wgpu 타입이 없게 합니다(지금은 공개 항목 약 서른 개가 wgpu 타입을 받거나 돌려주므로 wgpu의 새 주 버전이 나오면 깨집니다). 남은 것: 클라이언트 자신의 Metal·Vulkan·Direct3D 객체를 받는 호출은 실제로 쓰이기 전까지 잠정입니다. - [ ] **실제로 쓰이는 클라이언트 하나.** 별도 저장소의 브라우저 클라이언트 `emberwave-stream`이 Mac의 화면을 같은 Mac의 탭으로 스트리밍하는 것까지 됩니다. 로컬 네트워크를 건너는 것은 아직 보이지 못했습니다. 두 번째 기기가 필요하거나, 루프백 에뮬레이터로 대신해도 된다는 판단이 필요합니다. - [ ] **스트림 속도에서 업스트림과 같은 수준의 디코딩.** 4K는 도달했고, 1080p는 0.15~0.3 ms 느립니다([#150](https://github.com/with-developer/emberwave/issues/150)). - [ ] **패키지.** crates.io에는 `emberwave-core`와 `emberwave-cli` 0.18.1이 올라가 있습니다. 아직 없는 것은 브라우저 플레이어용 패키지와, Swift용으로 저장소 루트에 두는 `Package.swift`입니다(결정 D64: 릴리스 워크플로를 바꿔야 합니다). diff --git a/README.md b/README.md index 9c604f6..8573849 100644 --- a/README.md +++ b/README.md @@ -155,7 +155,7 @@ Next, each in a release when it is ready: 1.0.0 has no date. It is the promise that the C and Rust APIs stay compatible, and it will be tagged when the four things below are true; the maintainer makes that call. -- [ ] **Stable C and Rust APIs.** Settled: the rules by which the C API grows without breaking programs (decision D69), the shape of the Rust API (D70), and the shared library exporting the header's functions and nothing else, apart from four Objective-C names on macOS (D73). Open: the library's name carries no version yet, about thirty public items of the Rust API take or return wgpu's types (decision D70), which a new major version of wgpu would break, and the calls on a client's own Metal, Vulkan and Direct3D objects are provisional until a client has used them. The first two are put as a question in [#165](https://github.com/with-developer/emberwave/issues/165). +- [ ] **Stable C and Rust APIs.** Settled: the rules by which the C API grows without breaking programs (decision D69), the shape of the Rust API (D70), and the shared library exporting the header's functions and nothing else, apart from four Objective-C names on macOS (D73). Decided and still to do (D75, [#165](https://github.com/with-developer/emberwave/issues/165)): the shared library's name will carry the major version, and the GPU code will move into a crate of its own, `emberwave-wgpu`, so that `emberwave-core` has no wgpu type in its API (about thirty public items take or return wgpu's types today, which a new major version of wgpu would break). Open: the calls on a client's own Metal, Vulkan and Direct3D objects are provisional until a client has used them. - [ ] **One client in real use.** `emberwave-stream`, the browser client in a repository of its own, streams a Mac's screen to a tab on the same Mac. Across a local network it is not shown yet: that needs a second device, or the loopback emulator accepted in its place. - [ ] **Decoding at a stream's pace level with upstream's.** 4K is there; 1080p is 0.15 to 0.3 ms behind ([#150](https://github.com/with-developer/emberwave/issues/150)). - [ ] **Packages.** On crates.io: `emberwave-core` and `emberwave-cli`, 0.18.1. Not yet: a package for the browser player, and a `Package.swift` at the root of the repository for Swift (decision D64: the release workflow would have to change). diff --git a/crates/emberwave-cli/THIRD_PARTY_NOTICES.md b/crates/emberwave-cli/THIRD_PARTY_NOTICES.md new file mode 100644 index 0000000..5228fcc --- /dev/null +++ b/crates/emberwave-cli/THIRD_PARTY_NOTICES.md @@ -0,0 +1,34 @@ +# Third-party notices + +emberwave is licensed under the MIT license in [`LICENSE`](LICENSE). This file holds PyroWave's license, and what that license does not cover. + +## PyroWave + +emberwave is a reimplementation of PyroWave's decoder and encoder. It follows the algorithm structure and the bitstream format of PyroWave (), which is distributed under the following license: + +```text +Copyright (c) 2025 Hans-Kristian Arntzen + +Permission is hereby granted, free of charge, to any person obtaining +a copy of this software and associated documentation files (the +"Software"), to deal in the Software without restriction, including +without limitation the rights to use, copy, modify, merge, publish, +distribute, sublicense, and/or sell copies of the Software, and to +permit persons to whom the Software is furnished to do so, subject to +the following conditions: + +The above copyright notice and this permission notice shall be +included in all copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, +EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. +IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY +CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, +TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE +SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. +``` + +## Not covered: docs/images/quality.png + +`docs/images/quality.png` shows a frame of the game Crimson Desert, copyright Pearl Abyss Corp., as unofficial content under Pearl Abyss's fan content guidelines. It is not covered by the licenses in this file or in `LICENSE`. The source archives of releases leave it out. diff --git a/crates/emberwave-core/THIRD_PARTY_NOTICES.md b/crates/emberwave-core/THIRD_PARTY_NOTICES.md new file mode 100644 index 0000000..5228fcc --- /dev/null +++ b/crates/emberwave-core/THIRD_PARTY_NOTICES.md @@ -0,0 +1,34 @@ +# Third-party notices + +emberwave is licensed under the MIT license in [`LICENSE`](LICENSE). This file holds PyroWave's license, and what that license does not cover. + +## PyroWave + +emberwave is a reimplementation of PyroWave's decoder and encoder. It follows the algorithm structure and the bitstream format of PyroWave (), which is distributed under the following license: + +```text +Copyright (c) 2025 Hans-Kristian Arntzen + +Permission is hereby granted, free of charge, to any person obtaining +a copy of this software and associated documentation files (the +"Software"), to deal in the Software without restriction, including +without limitation the rights to use, copy, modify, merge, publish, +distribute, sublicense, and/or sell copies of the Software, and to +permit persons to whom the Software is furnished to do so, subject to +the following conditions: + +The above copyright notice and this permission notice shall be +included in all copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, +EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. +IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY +CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, +TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE +SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. +``` + +## Not covered: docs/images/quality.png + +`docs/images/quality.png` shows a frame of the game Crimson Desert, copyright Pearl Abyss Corp., as unofficial content under Pearl Abyss's fan content guidelines. It is not covered by the licenses in this file or in `LICENSE`. The source archives of releases leave it out. diff --git a/scripts/check_license_copies.sh b/scripts/check_license_copies.sh new file mode 100755 index 0000000..019574c --- /dev/null +++ b/scripts/check_license_copies.sh @@ -0,0 +1,20 @@ +#!/usr/bin/env bash +# The crates on crates.io carry LICENSE and THIRD_PARTY_NOTICES.md, since a +# package holds nothing outside its own directory (decisions D74 and D75). This +# checks that every copy is identical to the file at the root of the repository, +# so that a change to the root's goes into the copies too. +# +# Usage: scripts/check_license_copies.sh +set -euo pipefail + +cd "$(dirname "$0")/.." +status=0 +for crate in emberwave-core emberwave-cli; do + for file in LICENSE THIRD_PARTY_NOTICES.md; do + if ! cmp -s "$file" "crates/$crate/$file"; then + echo "crates/$crate/$file differs from $file: cp $file crates/$crate/$file" >&2 + status=1 + fi + done +done +exit $status