address code review comments

Author: Vit Nemecky

BrickController2/BrickController2/Extensions/ContainerBuilderExtensions.cs

@@ -52,7 +52,7 @@ internal static ContainerBuilder RegisterInputDeviceService<TInputDeviceService,
         where TInputDeviceService : IInputDeviceService<TInputDevice>, IStartable
         where TInputDevice : class, IInputDevice
     {
-        var registrationBuilder = RegisterInputDeviceService<TInputDeviceService>(builder)
+        RegisterInputDeviceService<TInputDeviceService>(builder)
             .As<IInputDeviceService<TInputDevice>>();
         return builder;
     }

BrickController2/BrickController2/InputDeviceManagement/DI/InputDeviceManagementModule.cs

@@ -11,7 +11,7 @@ protected override void Load(ContainerBuilder builder)
         {
             builder.RegisterType<InputDeviceManagerService>().As<IInputDeviceManagerService>().As<IInputDeviceEventServiceInternal>().As<IInputDeviceEventService>().SingleInstance();
 
-            // generic sensor based input device
+            // generic sensor based input device, but just if supported and enabled in Settings
             builder.RegisterInputDeviceService<InputSensorService, OrientationSensorController>();
         }
     }

BrickController2/BrickController2/InputDeviceManagement/Sensors/InputSensorService.cs

@@ -7,7 +7,7 @@ namespace BrickController2.InputDeviceManagement.Sensors;
 
 internal class InputSensorService : InputDeviceServiceBase<OrientationSensorController>, IInputDeviceService<OrientationSensorController>
 {
-    internal const string OrientationSensorEnabledKey = "OrientationSensorEnabled";
+    private const string TiltSensorEnabledKey = "TiltSensorEnabled";
 
     private readonly IInputDeviceEventServiceInternal _deviceEventServiceInternal;
     private readonly IPreferencesService _preferencesService;
@@ -26,8 +26,8 @@ public InputSensorService(IInputDeviceManagerService inputDeviceManagerService,
 
     public bool IsEnabled
     {
-        get => _preferencesService.Get(OrientationSensorEnabledKey, false);
-        set => _preferencesService.Set(OrientationSensorEnabledKey, value);
+        get => _preferencesService.Get(TiltSensorEnabledKey, false); // by default OFF
+        set => _preferencesService.Set(TiltSensorEnabledKey, value);
     }
 
     public bool IsSupported => Sensor.IsSupported;

BrickController2/BrickController2/InputDeviceManagement/Sensors/OrientationSensorController.cs

@@ -2,7 +2,7 @@
 using BrickController2.PlatformServices.InputDeviceService;
 using Microsoft.Maui.Devices.Sensors;
 using System;
-using System.Linq;
+using System.Collections.Generic;
 using System.Numerics;
 
 namespace BrickController2.InputDeviceManagement.Sensors;
@@ -11,13 +11,24 @@ public class OrientationSensorController : InputDeviceBase<IOrientationSensor>
 {
     private const double InversePI = 1.0 / Math.PI;
     private const double InverseHalfPI = 1.0 / (Math.PI / 2.0);
+    private const int RoundingPrecision = 4;
+
+    private const string PitchName = "Pitch";
+    private const string RollName = "Roll";
+    private const string YawName = "Yaw";
+
+    private static readonly (InputDeviceEventType, string) PitchKey = (InputDeviceEventType.Axis, PitchName);
+    private static readonly (InputDeviceEventType, string) RollKey = (InputDeviceEventType.Axis, RollName);
+    private static readonly (InputDeviceEventType, string) YawKey = (InputDeviceEventType.Axis, YawName);
+
+    private readonly Dictionary<(InputDeviceEventType, string), float> _eventBuffer = new(3);
 
     public OrientationSensorController(IInputDeviceEventServiceInternal service,
         IOrientationSensor sensor)
         : base(service, sensor)
     {
-        Name = "Orientation";
-        InputDeviceId = nameof(OrientationSensor);
+        InputDeviceId = "Sensor";
+        Name = "Tilt";
     }
 
     public override void Start()
@@ -38,23 +49,18 @@ public override void Stop()
 
     private void Orientation_ReadingChanged(object? sender, OrientationSensorChangedEventArgs e)
     {
-        var (Pitch, Roll, Yaw) = QuaternionToEulerAngles(e.Reading.Orientation);
-
-        RaiseEvents(
-        [
-            (nameof(Pitch), (float)Pitch),
-            (nameof(Roll), (float)Roll),
-            (nameof(Yaw), (float)Yaw)
-        ]);
-    }
+        var (pitch, roll, yaw) = QuaternionToEulerAngles(e.Reading.Orientation);
 
-    private void RaiseEvents((string eventName, float value)[] axisEvents)
-    {
-        var events = axisEvents
-            .Where(e => HasValueChanged(e.eventName, e.value))
-            .ToDictionary(e => (InputDeviceEventType.Axis, e.eventName), e => e.value);
+        _eventBuffer.Clear();
+
+        if (HasValueChanged(PitchName, pitch))
+            _eventBuffer[PitchKey] = pitch;
+        if (HasValueChanged(RollName, roll))
+            _eventBuffer[RollKey] = roll;
+        if (HasValueChanged(YawName, yaw))
+            _eventBuffer[YawKey] = yaw;
 
-        RaiseEvent(events);
+        RaiseEvent(_eventBuffer);
     }
 
     private static (float Pitch, float Roll, float Yaw) QuaternionToEulerAngles(Quaternion q)
@@ -77,9 +83,9 @@ private static (float Pitch, float Roll, float Yaw) QuaternionToEulerAngles(Quat
         var yaw = Math.Atan2(sinYaw, cosYaw);
 
         return (
-            (float)(pitch * InversePI), // <-180; 180> => <-1; 1>
-            (float)(roll * InverseHalfPI), // <-90; 90> => <-1; 1>
-            (float)(yaw * InversePI) // <-180; 180> => <-1; 1>
+            (float)Math.Round(pitch * InversePI, RoundingPrecision), // <-180; 180> => <-1; 1>
+            (float)Math.Round(roll * InverseHalfPI, RoundingPrecision), // <-90; 90> => <-1; 1>
+            (float)Math.Round(yaw * InversePI, RoundingPrecision) // <-180; 180> => <-1; 1>
         );
     }
 }

BrickController2/BrickController2/PlatformServices/InputDeviceService/IInputDeviceService.cs

@@ -28,4 +28,4 @@ public interface IInputDeviceService<TInputDevice> : IInputDeviceService
     /// Gets or sets a value whether the input device is enabled.
     /// </summary>
     bool IsEnabled { get; set; }
-}
+}

BrickController2/BrickController2/Resources/TranslationResources.de.resx

@@ -762,4 +762,7 @@
   <data name="SubchannelsPortMode" xml:space="preserve">
     <value>Subkanäle</value>
   </data>
+  <data name="OrientationSensor" xml:space="preserve">
+    <value>Neigungssteuerung</value>
+  </data>
 </root>

BrickController2/BrickController2/Resources/TranslationResources.hu.resx

@@ -753,4 +753,7 @@
   <data name="SubchannelsPortMode" xml:space="preserve">
     <value>Alcsatorna</value>
   </data>
+  <data name="OrientationSensor" xml:space="preserve">
+    <value>Dönthető kormányzás</value>
+  </data>
 </root>

BrickController2/BrickController2/Resources/TranslationResources.resx

@@ -763,6 +763,6 @@
     <value>Subchannels</value>
   </data>
   <data name="OrientationSensor" xml:space="preserve">
-    <value>Orientation Sensor</value>
+    <value>Tilt Steering</value>
   </data>
 </root>