Skip to content

Azure ADO git URL with spaces fails to validate #4101

Description

@seanhamlin

Describe the bug

The function GitUrlParse from git-url-parse [link] fails to validate Azure ADO repo URLs with spaces in them. This is valid in Azure ADO.

v16.1.0 of git-url-parse does not have this issue, this is confined to the old version Lagoon is running https://github.com/uselagoon/lagoon/blob/main/services/api/package.json#L45

The fix seems simple, update to the latest version of git-url-parse.

To Reproduce

lagoon update project -p project --git-url 'git@ssh.dev.azure.com:v3/org/Owner%20With%20Spaces/repo'
Error: graphql: The provided gitUrl is invalid.: check if the project exists

Expected behavior

Valid Azure ADO git URLs are accepted.

Related issue

#1743

Metadata

Metadata

Assignees

No one assigned

    Labels

    1-api-authAPI & Authentication subsystembug

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions