Skip to content

Commit 334d08d

Browse files
authored
Presubmit: run tests within test step, not benchmark (#253)
Not sure how this happened, but I think this is better.
1 parent 2dc4e9d commit 334d08d

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

.github/workflows/presubmit.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,11 @@ jobs:
3737
- name: Test
3838
run: |
3939
bazel test //ryu/... //src/...
40+
bazel test --copt=-DRYU_OPTIMIZE_SIZE //ryu/...
41+
bazel test --copt=-DRYU_ONLY_64_BIT_OPS //ryu/...
42+
bazel test --copt=-DRYU_OPTIMIZE_SIZE --copt=-DRYU_ONLY_64_BIT_OPS //ryu/...
43+
bazel test --copt=-DRYU_FLOAT_FULL_TABLE //ryu/...
44+
bazel test --copt=-DRYU_ONLY_64_BIT_OPS --copt=-DRYU_32_BIT_PLATFORM //ryu/...
4045
4146
- name: Leak checker (macOS)
4247
if: matrix.os == 'macos-latest' && success()
@@ -48,17 +53,13 @@ jobs:
4853
# machines are configured and what other things are run on the same
4954
# instances.
5055
- name: Benchmark
56+
shell: bash
5157
run: |
5258
bazel run -c opt //ryu/benchmark:ryu_benchmark --
5359
bazel run -c opt //ryu/benchmark:ryu_printf_benchmark -- -samples=200
54-
bazel test --copt=-DRYU_ONLY_64_BIT_OPS //ryu/...
5560
bazel run -c opt --copt=-DRYU_ONLY_64_BIT_OPS //ryu/benchmark:ryu_benchmark --
5661
bazel run -c opt --copt=-DRYU_ONLY_64_BIT_OPS //ryu/benchmark:ryu_printf_benchmark -- -samples=200
57-
bazel test --copt=-DRYU_OPTIMIZE_SIZE //ryu/...
5862
bazel run -c opt --copt=-DRYU_OPTIMIZE_SIZE //ryu/benchmark:ryu_benchmark --
5963
bazel run -c opt --copt=-DRYU_OPTIMIZE_SIZE //ryu/benchmark:ryu_printf_benchmark -- -samples=200
60-
bazel test --copt=-DRYU_OPTIMIZE_SIZE --copt=-DRYU_ONLY_64_BIT_OPS //ryu/...
6164
bazel run -c opt --copt=-DRYU_OPTIMIZE_SIZE --copt=-DRYU_ONLY_64_BIT_OPS //ryu/benchmark:ryu_benchmark
6265
bazel run -c opt --copt=-DRYU_OPTIMIZE_SIZE --copt=-DRYU_ONLY_64_BIT_OPS //ryu/benchmark:ryu_printf_benchmark -- -samples=200
63-
bazel test -c opt --copt=-DRYU_FLOAT_FULL_TABLE //ryu/...
64-
bazel test -c opt --copt=-DRYU_ONLY_64_BIT_OPS --copt=-DRYU_32_BIT_PLATFORM //ryu/...

0 commit comments

Comments
 (0)