fix: use cache bypass when searchOpenDialogs is used without forceSelect#744
Draft
Nanovsky wants to merge 3 commits into
Draft
fix: use cache bypass when searchOpenDialogs is used without forceSelect#744Nanovsky wants to merge 3 commits into
Nanovsky wants to merge 3 commits into
Conversation
This is tacling a UI5 specific in combination with WDI5 caching when enforceWebDriverClassic is used. UI5 destroys the dialog DOM when the dialog is closed and re-creates the DOM when the dialog is opened again. During this transition WDI5 internal caching holds on to the old DOM and thus resulting in a stale reference error. The fix is protocol agnostic for future proofing and only auto enables the forceSelect if it is not explicitly set by the test. Relevant to ui5-community#741
Separate cache-bypass from per-method re-retrieval for searchOpenDialogs selectors. Previously, auto-enabling forceSelect caused every method call to re-retrieve the element, timing out when the dialog was closed. Now only the control cache is bypassed, while the control instance retains normal behavior.
Collaborator
Author
|
Test is failing because of malformed URL: I'll investigate further why this URL is created like that. |
Nanovsky
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is tacling a UI5 specific in combination with WDI5 caching when enforceWebDriverClassic is used. UI5 destroys the dialog DOM when the dialog is closed and re-creates the DOM when the dialog is opened again. During this transition WDI5 internal caching holds on to the old DOM and thus resulting in a stale reference error.
The fix is protocol agnostic for future proofing and only use cache bypass for searchOpenDialogs if forceSelect is not explicitly set by the test.
Relevant to #741