Skip to content

Commit 84c2517

Browse files
committed
form-text is a div in place of a small tag
1 parent c79e481 commit 84c2517

7 files changed

Lines changed: 11 additions & 11 deletions

File tree

src/Elements/FormText.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ public function __construct(private readonly string $message)
1515

1616
public function render(): string
1717
{
18-
$html = '<small';
18+
$html = '<div';
1919
$html .= $this->renderAttributes();
2020
$html .= '>';
2121
$html .= $this->message;
2222

23-
return $html.'</small>';
23+
return $html.'</div>';
2424
}
2525
}

tests/BasicFormBuilderTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public function test_render_text_group_with_error_and_custom_form_text(): void
6565

6666
$this->builder->setErrorStore($errorStore);
6767

68-
$expected = '<div class="mb-3"><label for="email" class="form-label">Email</label><input type="text" name="email" class="form-control is-invalid" id="email"><div class="invalid-feedback">Email is required.</div><small class="form-text">some custom text</small></div>';
68+
$expected = '<div class="mb-3"><label for="email" class="form-label">Email</label><input type="text" name="email" class="form-control is-invalid" id="email"><div class="invalid-feedback">Email is required.</div><div class="form-text">some custom text</div></div>';
6969
$result = $this->form->text('Email', 'email')->formText('some custom text')->render();
7070
$this->assertEquals($expected, $result);
7171
}
@@ -702,7 +702,7 @@ public function test_render_number_group_with_error_and_custom_form_text(): void
702702

703703
$this->builder->setErrorStore($errorStore);
704704

705-
$expected = '<div class="mb-3"><label for="number" class="form-label">Number</label><input type="number" name="number" class="form-control is-invalid" id="number"><div class="invalid-feedback">Number is required.</div><small class="form-text">some custom text</small></div>';
705+
$expected = '<div class="mb-3"><label for="number" class="form-label">Number</label><input type="number" name="number" class="form-control is-invalid" id="number"><div class="invalid-feedback">Number is required.</div><div class="form-text">some custom text</div></div>';
706706
$result = $this->form->number('Number', 'number')->formText('some custom text')->render();
707707
$this->assertEquals($expected, $result);
708708
}

tests/CheckGroupTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public function test_renders_with_form_text(): void
9797

9898
$result = $checkGroup->render();
9999

100-
$this->assertEquals('<div class="form-check"><input type="checkbox" name="accept" value="1" class="form-check-input"><label class="form-check-label">Accept</label><small class="form-text">Required to continue.</small></div>', $result);
100+
$this->assertEquals('<div class="form-check"><input type="checkbox" name="accept" value="1" class="form-check-input"><label class="form-check-label">Accept</label><div class="form-text">Required to continue.</div></div>', $result);
101101
}
102102

103103
public function test_magic_call_delegates_to_control(): void

tests/FormGroupTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public function test_can_render_with_form_text(): void
8383
$formGroup = new FormGroup($label, $text);
8484
$formGroup->formText('Email is required.');
8585

86-
$expected = '<div class="mb-3"><label class="form-label">Email</label><input type="text" name="email"><small class="form-text">Email is required.</small></div>';
86+
$expected = '<div class="mb-3"><label class="form-label">Email</label><input type="text" name="email"><div class="form-text">Email is required.</div></div>';
8787
$result = $formGroup->render();
8888
$this->assertEquals($expected, $result);
8989
}

tests/FormTextTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ public function test_can_render_basic_form_text(): void
1515
{
1616
$formText = new FormText('Email is required.');
1717

18-
$expected = '<small class="form-text">Email is required.</small>';
18+
$expected = '<div class="form-text">Email is required.</div>';
1919
$result = $formText->render();
2020
$this->assertEquals($expected, $result);
2121

2222
$formText = new FormText('First name is required.');
2323

24-
$expected = '<small class="form-text">First name is required.</small>';
24+
$expected = '<div class="form-text">First name is required.</div>';
2525
$result = $formText->render();
2626
$this->assertEquals($expected, $result);
2727
}

tests/GroupWrapperTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ public function test_form_text_delegates_to_form_group(): void
159159
$wrapper = $this->makeWrapper();
160160
$wrapper->formText('Enter your email address.');
161161

162-
$this->assertStringContainsString('<small class="form-text">Enter your email address.</small>', $wrapper->render());
162+
$this->assertStringContainsString('<div class="form-text">Enter your email address.</div>', $wrapper->render());
163163
}
164164

165165
public function test_form_text_returns_self_for_chaining(): void

tests/HorizontalFormGroupTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,9 @@ public function test_renders_form_text_inside_control_column(): void
8989

9090
$result = $group->render();
9191

92-
$this->assertStringContainsString('<small class="form-text">We will never share your email.</small>', $result);
92+
$this->assertStringContainsString('<div class="form-text">We will never share your email.</div>', $result);
9393
$controlDivPos = strpos($result, '<div class="col-lg-10">');
94-
$formTextPos = strpos($result, '<small class="form-text">');
94+
$formTextPos = strpos($result, '<div class="form-text">');
9595
$this->assertGreaterThan($controlDivPos, $formTextPos, 'Form text must be inside the control column div');
9696
}
9797

0 commit comments

Comments
 (0)