Swiped items returns to the ListView for a brief moment

[milosgh]

Hi,

I've noticed one GUI glitch when I swipe away the item in the ListView just before the 'Undo' pop-up shows up on the screen.
This is the scenario when I have 3 items for example:

1. I swipe away 2nd one
2. Animation that moves 3rd one in a place for 2nd one finishes
   problematic 3) 2nd item reappears in the ListView for a second before my Adapter data gets updated and is ready to show just 2 items without the deleted one.

So, the swiped item is shown briefly during the delay of ListView update. I've looked into the code and saw that this block of code does that:
#613 ViewGroup.LayoutParams lp;
#614 for (PendingDismissData pendingDismiss : mPendingDismisses) {
#615 // Reset view presentation
#616 setAlpha(pendingDismiss.view, 1f);
#617 setTranslationX(pendingDismiss.view, 0);
#618 lp = pendingDismiss.view.getLayoutParams();
#619 lp.height = originalHeight;
#620 pendingDismiss.view.setLayoutParams(lp);
#621 }
#623 mPendingDismisses.clear();

Why are you re-showing the dismissed item?
When I tried to remove this block of code, the behaviour is weird, sometimes two items got dismissed etc.

Can you please take a look at this?

Thanks,
Milos

[timroes]

Hi, thanks for the bug report. Never noticed that behavior. The code part you posted it from the original snippet I based my code on. I will have a look at it and hopefully fix it within the next 2 days. Cheers Tim

[milosgh]

Now I optimized Adapter update so I no longer see the glitch.
So, the problem appears when this Adapter update takes 'too long'..or you can easily see this behaviour it by not calling mAdapter.remove() method when item is dismissed. Cheers

[vishna]

Experiencing the same issue. The problem here is that after notifyDataSetChanged the view_x which had item_n associated, will now try to load item_n+1. Much faster approach would be to replace view_x with view_x+1 in the view cache. Not really sure if that's doable though.

[timroes]

Couldn't fix it, since the way you delete items is totally up to you. So I have no chance of knowing when you finished, if you do it in another thread. But added a documentation to the onDismiss method of the new library, that you must not return from that method, before your deletion finished. So synchronizing is up to the developer, because she is the only one, who knows when the deletion finished.

https://github.com/timroes/EnhancedListView

[LouisCAD]

Adding a callback, or implement it in the super implementation would allow us to tell when deletion is done