chore: upgrade flutter version, migrate deprecated API

Author: hjiangsu

.github/workflows/ci.yml

@@ -26,7 +26,7 @@ jobs:
 
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.41.x'
+          flutter-version: '3.44.x'
           channel: "stable"
           cache: true
           cache-key: 'flutter-:os:-:channel:-:version:-:arch:-:hash:' # optional, change this to force refresh cache

.github/workflows/release.yml

@@ -62,7 +62,7 @@ jobs:
       - name: Set up Flutter
         uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.41.x' # When updating this, also update the corresponding f-droid metadata file
+          flutter-version: '3.44.x' # When updating this, also update the corresponding f-droid metadata file
           channel: 'stable'
           cache: true
 
@@ -127,7 +127,7 @@ jobs:
       - name: Set up Flutter
         uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.41.x' # When updating this, also update the corresponding f-droid metadata file
+          flutter-version: '3.44.x' # When updating this, also update the corresponding f-droid metadata file
           channel: 'stable'
           cache: true
 

android/build.gradle

@@ -16,6 +16,57 @@ subprojects {
     project.buildDir = "${rootProject.buildDir}/${project.name}"
 }
 
+subprojects { subproject ->
+    def configureJavaJvmTarget = {
+        if (subproject.plugins.hasPlugin("com.android.application") || subproject.plugins.hasPlugin("com.android.library")) {
+            subproject.android {
+                compileOptions {
+                    sourceCompatibility JavaVersion.VERSION_17
+                    targetCompatibility JavaVersion.VERSION_17
+                }
+            }
+        }
+
+        subproject.tasks.withType(JavaCompile).configureEach {
+            sourceCompatibility = JavaVersion.VERSION_17.toString()
+            targetCompatibility = JavaVersion.VERSION_17.toString()
+        }
+    }
+
+    def configureKotlinJvmTarget = {
+        subproject.tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).configureEach {
+            if (subproject.name == "flutter_avif_android") {
+                exclude("**/FlutterAvifPlugin.kt")
+            }
+
+            kotlinOptions {
+                jvmTarget = JavaVersion.VERSION_17.toString()
+            }
+        }
+    }
+
+    plugins.withId("com.android.application") {
+        configureJavaJvmTarget()
+    }
+
+    plugins.withId("com.android.library") {
+        configureJavaJvmTarget()
+    }
+
+    plugins.withId("org.jetbrains.kotlin.android") {
+        configureKotlinJvmTarget()
+    }
+
+    plugins.withId("kotlin-android") {
+        configureKotlinJvmTarget()
+    }
+
+    afterEvaluate {
+        configureJavaJvmTarget()
+        configureKotlinJvmTarget()
+    }
+}
+
 subprojects {
     project.evaluationDependsOn(':app')
 }

android/gradle.properties

@@ -4,3 +4,5 @@ android.enableJetifier=true
 android.defaults.buildfeatures.buildconfig=true
 android.nonTransitiveRClass=false
 android.nonFinalResIds=false
+android.builtInKotlin=false
+android.newDsl=false

flutter

@@ -1,6 +1,7 @@
 import 'dart:async';
 import 'dart:io';
 
+import 'package:flutter/cupertino.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
 

lib/src/app/shell/thunder_app.dart

@@ -59,9 +59,10 @@ class _ProfileModalBodyState extends State<ProfileModalBody> {
   Widget build(BuildContext context) {
     return Navigator(
       key: ProfileModalBody.shellNavigatorKey,
-      onPopPage: (route, result) => false,
+      onDidRemovePage: (_) {},
       pages: [
         MaterialPage(
+          canPop: false,
           child: ProfileSelect(
             pushRegister: pushRegister,
             showLogoutDialog: widget.showLogoutDialog,
@@ -206,11 +207,8 @@ class _ProfileSelectState extends State<ProfileSelect> {
               SliverReorderableList(
                 onReorderStart: (index) => setState(() => accountBeingReorderedIndex = index),
                 onReorderEnd: (index) => setState(() => accountBeingReorderedIndex = null),
-                onReorder: (int oldIndex, int newIndex) {
+                onReorderItem: (int oldIndex, int newIndex) {
                   setState(() {
-                    if (oldIndex < newIndex) {
-                      newIndex -= 1;
-                    }
                     final AccountExtended item = accounts!.removeAt(oldIndex);
                     accounts!.insert(newIndex, item);
                   });
@@ -452,11 +450,8 @@ class _ProfileSelectState extends State<ProfileSelect> {
                 SliverReorderableList(
                   onReorderStart: (index) => setState(() => anonymousInstanceBeingReorderedIndex = index),
                   onReorderEnd: (index) => setState(() => anonymousInstanceBeingReorderedIndex = null),
-                  onReorder: (int oldIndex, int newIndex) {
+                  onReorderItem: (int oldIndex, int newIndex) {
                     setState(() {
-                      if (oldIndex < newIndex) {
-                        newIndex -= 1;
-                      }
                       final AnonymousInstanceExtended item = anonymousInstances!.removeAt(oldIndex);
                       anonymousInstances!.insert(newIndex, item);
                     });

lib/src/features/account/presentation/widgets/profile_modal_body.dart

@@ -282,7 +282,7 @@ Future<void> _showMessageNotifications({
 
 /// This method handles "headless" callbacks (i.e., whent the app is not running)
 @pragma('vm:entry-point')
-void backgroundFetchHeadlessTask(HeadlessTask task) async {
+void backgroundFetchHeadlessTask(HeadlessEvent task) async {
   if (task.timeout) return BackgroundFetch.finish(task.taskId);
 
   // Ensure Flutter bindings are initialized for background isolate
@@ -306,7 +306,7 @@ void backgroundFetchHeadlessTask(HeadlessTask task) async {
 
 /// This method handles "headless" callbacks for testing
 @pragma('vm:entry-point')
-void backgroundTestFetchHeadlessTask(HeadlessTask task) async {
+void backgroundTestFetchHeadlessTask(HeadlessEvent task) async {
   if (task.timeout) return BackgroundFetch.finish(task.taskId);
 
   await showTestAndroidNotification();

lib/src/features/notification/presentation/utils/local_notification_utils.dart

@@ -1,4 +1,5 @@
 import 'package:flutter/material.dart';
+import 'package:flutter/rendering.dart';
 
 import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:super_sliver_list/super_sliver_list.dart';
@@ -58,7 +59,7 @@ class PostPageScrollBody extends StatelessWidget {
   Widget build(BuildContext context) {
     return CustomScrollView(
       controller: scrollController,
-      cacheExtent: 1000,
+      scrollCacheExtent: ScrollCacheExtent.pixels(1000),
       slivers: [
         PostPageAppBar(
           key: appBarKey,

lib/src/features/post/presentation/widgets/post_page_scroll_body.dart

@@ -3,7 +3,6 @@ import 'package:flutter/widgets.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
 
 import 'package:thunder/src/features/settings/api.dart';
-import 'package:thunder/src/shared/name/name_style.dart' show FullNameSeparator;
 import 'package:thunder/src/shared/name/name_formatting.dart' show formatCommunityFullNamePrefix, formatCommunityFullNameSuffix, formatUserFullNamePrefix, formatUserFullNameSuffix;
 
 export 'package:thunder/src/shared/name/name_style.dart' show FullNameSeparator, NameColor, NameThickness;