You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR focuses on updating the calculation of percentage changes and formatting for better clarity in the Payouts, common, and PayNewCustomers components.
Detailed summary
In Payouts.tsx, updated the trend calculation to handle cases where lastPeriod.value is 0, returning 100 instead of performing division.
In common.tsx, replaced the display of percentValue with a formatted string using Intl.NumberFormat to show percentage without decimal places.
In PayNewCustomers.tsx, similar trend calculation adjustment as in Payouts.tsx to improve handling of zero values.
✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DashboardInvolves changes to the Dashboard.merge-queueAdds the pull request to Graphite's merge queue.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on updating the calculation of percentage changes and formatting for better clarity in the
Payouts,common, andPayNewCustomerscomponents.Detailed summary
Payouts.tsx, updated the trend calculation to handle cases wherelastPeriod.valueis0, returning100instead of performing division.common.tsx, replaced the display ofpercentValuewith a formatted string usingIntl.NumberFormatto show percentage without decimal places.PayNewCustomers.tsx, similar trend calculation adjustment as inPayouts.tsxto improve handling of zero values.