Skip to content

Commit 3173a7e

Browse files
author
Zachary Whitley
committed
fix(ci): export LIBSQLITE3_FLAGS with SESSION + PREUPDATE_HOOK
host's session/changeset subcommand links against sqlite3session_* + sqlite3changeset_* which require the SESSION + PREUPDATE_HOOK features in libsqlite3-sys's bundled amalgamation. The local dev flow gets these via the [env] block of .cargo/config.toml (created by scripts/setup-cargo-config.sh from the template). CI doesn't run that script + .cargo/config.toml is gitignored, so the amalgamation compiled without the flags and host's link failed with 'undefined symbol: sqlite3session_attach' (+12 more). Mirror the template's LIBSQLITE3_FLAGS line directly into ci.yml's workflow env. Wasm-smoke is unaffected (already runs the setup script alongside the wasi-sdk download).
1 parent 4517e65 commit 3173a7e

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,14 @@ env:
2020
# enough to OOM smaller runners.
2121
CARGO_PROFILE_DEV_DEBUG: "0"
2222
CARGO_PROFILE_TEST_DEBUG: "0"
23+
# libsqlite3-sys honors LIBSQLITE3_FLAGS to thread extra -D into
24+
# its bundled amalgamation compile. host's session/changeset
25+
# subcommand needs SESSION + PREUPDATE_HOOK. Mirrors the
26+
# .cargo/config.toml.template's [env] block so CI builds match
27+
# local dev. The template is gitignored after
28+
# scripts/setup-cargo-config.sh substitutes wasi-sdk path; CI
29+
# doesn't need wasi-sdk for native checks so export directly here.
30+
LIBSQLITE3_FLAGS: "-DSQLITE_ENABLE_GEOPOLY -DSQLITE_ENABLE_DBSTAT_VTAB -DSQLITE_ENABLE_STMTVTAB -DSQLITE_ENABLE_BYTECODE_VTAB -DSQLITE_ENABLE_SESSION -DSQLITE_ENABLE_PREUPDATE_HOOK -DSQLITE_ENABLE_DESERIALIZE -DSQLITE_DEFAULT_MEMSTATUS=0 -DSQLITE_THREADSAFE=0 -DSQLITE_LIKE_DOESNT_MATCH_BLOBS -DSQLITE_MAX_EXPR_DEPTH=0 -DSQLITE_OMIT_DEPRECATED -DSQLITE_DEFAULT_AUTOMATIC_INDEX=0 -DSQLITE_USE_ALLOCA"
2331

2432
jobs:
2533
host-checks:

0 commit comments

Comments
 (0)