Skip to content

Commit 29b2b79

Browse files
committed
Update ios-release.yml
1 parent 26250cc commit 29b2b79

1 file changed

Lines changed: 9 additions & 13 deletions

File tree

.github/workflows/ios-release.yml

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -240,15 +240,6 @@ jobs:
240240
echo "IOS_PROFILE_UUID=$PROFILE_UUID" >> "$GITHUB_ENV"
241241
echo "IOS_PROFILE_NAME=$PROFILE_NAME" >> "$GITHUB_ENV"
242242
243-
- name: Set version variables
244-
shell: bash
245-
run: |
246-
DISPLAY_BASE="$(python3 -c 'import os, xml.etree.ElementTree as ET; root = ET.parse(os.environ["PROJECT_PATH"]).getroot(); print(next((node.text.strip() for group in root.findall("PropertyGroup") for node in [group.find("ApplicationDisplayVersion")] if node is not None and node.text), "1.0"))')"
247-
248-
BUILD_NUMBER="${{ github.run_number }}"
249-
echo "VERSION_DISPLAY=$DISPLAY_BASE.$BUILD_NUMBER" >> "$GITHUB_ENV"
250-
echo "VERSION_BUILD=$BUILD_NUMBER" >> "$GITHUB_ENV"
251-
252243
- name: Restore NuGet packages
253244
shell: bash
254245
run: |
@@ -266,9 +257,7 @@ jobs:
266257
-p:BuildIpa=true \
267258
-p:ProvisioningType=manual \
268259
-p:CodesignKey="$IOS_CODESIGN_KEY_RESOLVED" \
269-
-p:CodesignProvision="$IOS_PROFILE_NAME" \
270-
-p:ApplicationDisplayVersion="$VERSION_DISPLAY" \
271-
-p:ApplicationVersion="$VERSION_BUILD"
260+
-p:CodesignProvision="$IOS_PROFILE_NAME"
272261
273262
- name: Collect IPA artifact
274263
shell: bash
@@ -316,6 +305,8 @@ jobs:
316305
- name: Upload build to App Store Connect
317306
shell: bash
318307
run: |
308+
set -e # Exit immediately if any command fails
309+
319310
IPA_PATH="$(find downloaded-ipa -type f -name "*.ipa" | head -n 1)"
320311
321312
if [[ -z "$IPA_PATH" ]]; then
@@ -332,4 +323,9 @@ jobs:
332323
--verbose
333324
)
334325
335-
xcrun altool "${ALTOOL_ARGS[@]}"
326+
if ! xcrun altool "${ALTOOL_ARGS[@]}"; then
327+
echo "App Store Connect upload failed. Check the detailed error messages above."
328+
exit 1
329+
fi
330+
331+
echo "Build successfully uploaded to App Store Connect."

0 commit comments

Comments
 (0)