Fix truncation - only modify generated row's value

Author: mrliptontea

src/mongo/delegates/Tables.php

@@ -649,26 +649,24 @@ protected function truncateFields(Collection $collection, array &$generatedRow):
         }
 
         if ($indexedFields !== [] && isset($generatedRow['value']) && is_array($generatedRow['value'])) {
-            // Iterate over generated rows BY REFERENCE (&) - we are going to modify the contents of $field
-            foreach ($generatedRow as &$field) {
-                foreach ($indexedFields as $indexedFieldname) {
-                    // The key will have the index name in the following format added to it.
-                    // Adjust the max key size allowed to take it into account.
-                    $maxKeySize = 1020 - strlen('value_' . $indexedFieldname . '_1');
-
-                    // It's important that we count the number of bytes
-                    // in the field - not just the number of characters.
-                    // UTF-8 characters can be between 1 and 4 bytes.
-                    //
-                    // From the strlen documentation:
-                    //     Attention with utf8:
-                    //     $foo = "bär";
-                    //     strlen($foo) will return 4 and not 3 as expected..
-                    //
-                    // So strlen does count the bytes - not the characters.
-                    if (array_key_exists($indexedFieldname, $field) && (is_string($field[$indexedFieldname]) && strlen($field[$indexedFieldname]) > $maxKeySize)) {
-                        $field[$indexedFieldname] = substr($field[$indexedFieldname], 0, $maxKeySize);
-                    }
+            $value = &$generatedRow['value'];
+            foreach ($indexedFields as $indexedFieldname) {
+                // The key will have the index name in the following format added to it.
+                // Adjust the max key size allowed to take it into account.
+                $maxKeySize = 1020 - strlen('value_' . $indexedFieldname . '_1');
+
+                // It's important that we count the number of bytes
+                // in the field - not just the number of characters.
+                // UTF-8 characters can be between 1 and 4 bytes.
+                //
+                // From the strlen documentation:
+                //     Attention with utf8:
+                //     $foo = "bär";
+                //     strlen($foo) will return 4 and not 3 as expected..
+                //
+                // So strlen does count the bytes - not the characters.
+                if (array_key_exists($indexedFieldname, $value) && (is_string($value[$indexedFieldname]) && strlen($value[$indexedFieldname]) > $maxKeySize)) {
+                    $value[$indexedFieldname] = substr($value[$indexedFieldname], 0, $maxKeySize);
                 }
             }
         }