Skip to content
This repository was archived by the owner on Nov 8, 2018. It is now read-only.

installed pytest dependency,added runner#367

Open
nfebe wants to merge 1 commit into
systers:developfrom
nfebe:add-pytest
Open

installed pytest dependency,added runner#367
nfebe wants to merge 1 commit into
systers:developfrom
nfebe:add-pytest

Conversation

@nfebe

@nfebe nfebe commented Jul 10, 2018

Copy link
Copy Markdown

Signed-off-by: Fenn-25 fenn25.fn@gmail.com

Description

Installed pytest and added test runner.

Fixes #363

Type of Change:

  • Code
  • Quality Assurance

How Has This Been Tested?

Run locally

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Signed-off-by: Fenn-25 <fenn25.fn@gmail.com>
Comment thread .gitignore
*.DS_Store
*/migrations/
credentials.json
.pytest_cache No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line :p

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fenn-cs, Not needed but you may wanna add .coverage* and coverage.xml to .gitignore as well.

Comment thread pytest.ini
@@ -0,0 +1,2 @@
[pytest]
DJANGO_SETTINGS_MODULE = infohub.settings No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line :p

@MehaKaushik MehaKaushik left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address @Monal5031's comments. Everything else seems good.

@nfebe

nfebe commented Jul 13, 2018 via email

Copy link
Copy Markdown
Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants