Skip to content

Commit e274fe5

Browse files
authored
Upgrade from Node 20 to Node 24
This is to upgrade from Node 20 to Node 24.
1 parent 818ac4b commit e274fe5

5 files changed

Lines changed: 22 additions & 19 deletions

File tree

.github/workflows/build.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111

1212
steps:
1313
# 1 – Check out the code
14-
- uses: actions/checkout@v4
14+
- uses: actions/checkout@v6
1515

1616
# 2 – Expose the version tag as $PACKAGE_VERSION (only if this is a v* tag ref)
1717
- name: Set environment package version from tag
@@ -25,20 +25,20 @@ jobs:
2525
fi
2626
2727
# 3 – Set up Python
28-
- uses: actions/setup-python@v5
28+
- uses: actions/setup-python@v6
2929
with:
3030
python-version: '3.13'
3131
cache: 'pip'
3232

3333
# 4 – Set up Node.js
34-
- uses: actions/setup-node@v4
34+
- uses: actions/setup-node@v6
3535
with:
36-
node-version: '20.x'
36+
node-version: '24.x'
3737
cache: 'npm'
3838

3939
# 5 – Set up JDK 17 and enable sbt cache
4040
- name: Set up JDK 17
41-
uses: actions/setup-java@v4
41+
uses: actions/setup-java@v5
4242
with:
4343
distribution: 'temurin'
4444
java-version: '17'
@@ -68,4 +68,4 @@ jobs:
6868

6969
# 11 – Run tests
7070
- name: Run tests
71-
run: pytest
71+
run: pytest

.github/workflows/checks.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,17 @@ jobs:
1515
check-code:
1616
runs-on: ubuntu-latest
1717
steps:
18-
- uses: actions/checkout@v4
18+
- uses: actions/checkout@v6
1919

2020
- name: Setup Node.js environment
21-
uses: actions/setup-node@v4
21+
uses: actions/setup-node@v6
2222
with:
23-
node-version: 20.x
23+
node-version: 24.x
2424
cache: yarn
2525
cache-dependency-path: yarn.lock
2626

2727
- name: Setup Python
28-
uses: actions/setup-python@v5
28+
uses: actions/setup-python@v6
2929
with:
3030
python-version: '3.13'
3131

.github/workflows/publish.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414

1515
steps:
1616
# 1 – Check out the repo
17-
- uses: actions/checkout@v4
17+
- uses: actions/checkout@v6
1818

1919
# 2 – Expose the tag (e.g. 1.2.3) as $PACKAGE_VERSION
2020
- name: Set environment package version from tag
@@ -24,20 +24,20 @@ jobs:
2424
echo "PACKAGE_VERSION=${ref#v}" >> "$GITHUB_ENV"
2525
2626
# 3 – Set up Python
27-
- uses: actions/setup-python@v5
27+
- uses: actions/setup-python@v6
2828
with:
2929
python-version: '3.13'
3030
cache: 'pip'
3131

3232
# 4 – Set up Node.js
33-
- uses: actions/setup-node@v4
33+
- uses: actions/setup-node@v6
3434
with:
35-
node-version: '20.x'
35+
node-version: '24.x'
3636
cache: 'npm'
3737

3838
# 5 – Set up JDK 17 and enable sbt cache
3939
- name: Set up JDK 17
40-
uses: actions/setup-java@v4
40+
uses: actions/setup-java@v5
4141
with:
4242
distribution: 'temurin'
4343
java-version: '17'
@@ -59,4 +59,4 @@ jobs:
5959

6060
# 9 – Publish to PyPI (Trusted Publishing)
6161
- name: Publish distribution to PyPI 🚀
62-
uses: pypa/gh-action-pypi-publish@release/v1
62+
uses: pypa/gh-action-pypi-publish@release/v1

.github/workflows/release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ jobs:
1212
bump-version:
1313
runs-on: ubuntu-latest
1414
steps:
15-
- uses: actions/checkout@v4
15+
- uses: actions/checkout@v6
1616
with:
1717
persist-credentials: false
18-
- uses: actions/setup-python@v5
18+
- uses: actions/setup-python@v6
1919
with:
2020
python-version: '3.13'
2121
- uses: BSFishy/pip-action@v1
@@ -31,4 +31,4 @@ jobs:
3131
uses: ad-m/github-push-action@master
3232
with:
3333
github_token: ${{ secrets.WORKFLOW_ACCESS_TOKEN }}
34-
tags: true
34+
tags: true

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@
2929
"url": "https://github.com/swan-cern/sparkmonitor/issues"
3030
},
3131
"homepage": "https://github.com/swan-cern/sparkmonitor",
32+
"engines": {
33+
"node": ">=24 <25"
34+
},
3235
"scripts": {
3336
"build": "jlpm run build:lib && jlpm run build:labextension:dev",
3437
"build:prod": "jlpm clean && jlpm run build:lib:prod && jlpm run build:labextension && jlpm run build:nbextension && jlpm run build:scalalistener",

0 commit comments

Comments
 (0)