Skip to content

Commit 6954bbb

Browse files
committed
🐛(frontend) fix search-modal issues
QuickSearchItem takes an `alwaysShowRight` prop but this right container was only gated to `isDesktop` so on small viewports, no matter the value of `alwaysShowRight` items were hidden. Then we also fix a little style issue with dark theme, the quick search input had the default browser background.
1 parent daff5ac commit 6954bbb

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

src/components/quick-search/QuickSearchItemTemplate.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export const QuickSearchItemTemplate = ({
2020
<div className="c__quick-search-item-template" data-testid={testId}>
2121
<div className="c__quick-search-item-template__left">{left}</div>
2222

23-
{isDesktop && right && (
23+
{(isDesktop || alwaysShowRight) && right && (
2424
<div
2525
className={clsx("c__quick-search-item-template__right", {
2626
"always-show-right": alwaysShowRight,

src/components/quick-search/index.scss

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,16 @@
99
color: var(--c--contextuals--content--semantic--neutral--tertiary);
1010
}
1111

12-
.quick-search-input {
12+
input.quick-search-input {
13+
background: transparent;
14+
border: none;
15+
outline: none;
16+
color: var(--c--contextuals--content--semantic--neutral--primary);
17+
1318
&::placeholder {
1419
color: var(
1520
--c--contextuals--content--semantic--neutral--tertiary
16-
) !important;
21+
);
1722
}
1823
}
1924
}

0 commit comments

Comments
 (0)