Help modal: close button without accessible name and decorative icon being announced

[cyberbaloo]

Observed behavior

The close button of the help modal does not have an accessible name. The icon it contains is not hidden from assistive technologies, which results in inconsistent button announcement.

Expected behavior

The close button must have an explicit accessible name (e.g., "Close"). The icon must be hidden via aria-hidden="true".

Steps to reproduce

1. Open the help modal
2. Navigate with a screen reader to the close button
3. Notice that the button is announced without an explicit name or with the icon description

Possible solution

<!-- Before -->
<button type="button">
  <svg><!-- cross icon --></svg>
</button>

<!-- After -->
<button aria-label="Close">
  <svg aria-hidden="true"><!-- cross icon --></svg>
</button>

RGAA criteria

Critère 7.1 : Chaque script est-il, si nécessaire, compatible avec les technologies d'assistance ?

Impact

A blind user navigating with a screen reader reaches the close button of the help modal without being able to identify its function: the button is announced without a name or with the raw description of the icon.

Priority

P1

[Ovgodd]

this will be fix in this PR on Cunningham side