From 86ef0ff43962814d7ed6628ef0e57d515d3e6f9e Mon Sep 17 00:00:00 2001 From: mbx30 <212453881+mberrys@users.noreply.github.com> Date: Sun, 27 Sep 2026 17:08:00 -0700 Subject: [PATCH 1/3] docs(github): rename PR template anti-slop pass to quality pass Co-Authored-By: Claude Opus 5.5 --- .github/pull_request_template.md | 4 ++-- changes/cc-pr-template-quality-pass.md | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 changes/cc-pr-template-quality-pass.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 186840154..5d7ca7f5b 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -22,7 +22,7 @@ - [ ] Invalid state stops before partial mutation or publication and returns a descriptive error or result - [ ] Names carry the domain intent, and comments explain rationale rather than restating the code -## Anti-slop pass +## Quality pass - [ ] Redundant or explanatory comments that do not match the file's style removed - [ ] Abnormal defensive checks and broad try/catch blocks removed where a trusted upstream boundary already guarantees the invariant, with real boundary and safety checks kept @@ -31,7 +31,7 @@ - [ ] Generated boilerplate, needless wrappers, and local-style drift removed - [ ] Validation, security, cancellation, provenance, and failure handling preserved -Anti-slop summary (1-3 sentences): +Quality summary (1-3 sentences): diff --git a/changes/cc-pr-template-quality-pass.md b/changes/cc-pr-template-quality-pass.md new file mode 100644 index 000000000..adb8ab5ac --- /dev/null +++ b/changes/cc-pr-template-quality-pass.md @@ -0,0 +1,4 @@ +Category: internal +Audience: contributors +Breaking-Change: no +Summary: Rename the pull request template's "Anti-slop pass" section and summary to "Quality pass" and "Quality summary"; the checklist items are unchanged. From d6238b43e2954c0e69450cf299ef1c82d780402f Mon Sep 17 00:00:00 2001 From: mbx30 <212453881+mberrys@users.noreply.github.com> Date: Sun, 27 Sep 2026 17:10:10 -0700 Subject: [PATCH 2/3] docs(agent): ask for a quality summary in the policy handoff Co-Authored-By: Claude Opus 5.5 --- .claude/policy-brief.md | 2 +- .cursor/agent-policy.md | 2 +- AGENTS.md | 2 +- agent-policy.json | 2 +- changes/cc-pr-template-quality-pass.md | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.claude/policy-brief.md b/.claude/policy-brief.md index 9e7fc7410..d34ed5510 100644 --- a/.claude/policy-brief.md +++ b/.claude/policy-brief.md @@ -62,7 +62,7 @@ Every agent-authored or materially agent-modified diff, as a final pass before t - Remove generated boilerplate, needless wrappers and abstractions, and other local-style drift. Preserve required validation, security, cancellation, provenance, and failure handling. -Re-run the owning issue's normal verification after the pass, and record a 1-3 sentence anti-slop summary in the handoff. +Re-run the owning issue's normal verification after the pass, and record a 1-3 sentence quality summary in the handoff. The pass is review judgment on the diff; do not add brittle automated style metrics. Canonical policy: Berry Studio BSP-002 §4.2 and §4.3 (https://app.notion.com/p/3b39cb079ddb811d8527ed129c3ac511). diff --git a/.cursor/agent-policy.md b/.cursor/agent-policy.md index 5bc5d2b83..2aba0ef90 100644 --- a/.cursor/agent-policy.md +++ b/.cursor/agent-policy.md @@ -62,7 +62,7 @@ Every agent-authored or materially agent-modified diff, as a final pass before t - Remove generated boilerplate, needless wrappers and abstractions, and other local-style drift. Preserve required validation, security, cancellation, provenance, and failure handling. -Re-run the owning issue's normal verification after the pass, and record a 1-3 sentence anti-slop summary in the handoff. +Re-run the owning issue's normal verification after the pass, and record a 1-3 sentence quality summary in the handoff. The pass is review judgment on the diff; do not add brittle automated style metrics. Canonical policy: Berry Studio BSP-002 §4.2 and §4.3 (https://app.notion.com/p/3b39cb079ddb811d8527ed129c3ac511). diff --git a/AGENTS.md b/AGENTS.md index cfb0d0d95..f2109f846 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -62,7 +62,7 @@ Every agent-authored or materially agent-modified diff, as a final pass before t - Remove generated boilerplate, needless wrappers and abstractions, and other local-style drift. Preserve required validation, security, cancellation, provenance, and failure handling. -Re-run the owning issue's normal verification after the pass, and record a 1-3 sentence anti-slop summary in the handoff. +Re-run the owning issue's normal verification after the pass, and record a 1-3 sentence quality summary in the handoff. The pass is review judgment on the diff; do not add brittle automated style metrics. Canonical policy: Berry Studio BSP-002 §4.2 and §4.3 (https://app.notion.com/p/3b39cb079ddb811d8527ed129c3ac511). diff --git a/agent-policy.json b/agent-policy.json index e06ffff2a..4b0c0af13 100644 --- a/agent-policy.json +++ b/agent-policy.json @@ -63,7 +63,7 @@ ], "preserve": "Preserve required validation, security, cancellation, provenance, and failure handling.", "closing": [ - "Re-run the owning issue's normal verification after the pass, and record a 1-3 sentence anti-slop summary in the handoff.", + "Re-run the owning issue's normal verification after the pass, and record a 1-3 sentence quality summary in the handoff.", "The pass is review judgment on the diff; do not add brittle automated style metrics.", "Canonical policy: Berry Studio BSP-002 §4.2 and §4.3 (https://app.notion.com/p/3b39cb079ddb811d8527ed129c3ac511)." ] diff --git a/changes/cc-pr-template-quality-pass.md b/changes/cc-pr-template-quality-pass.md index adb8ab5ac..a79e02408 100644 --- a/changes/cc-pr-template-quality-pass.md +++ b/changes/cc-pr-template-quality-pass.md @@ -1,4 +1,4 @@ Category: internal Audience: contributors Breaking-Change: no -Summary: Rename the pull request template's "Anti-slop pass" section and summary to "Quality pass" and "Quality summary"; the checklist items are unchanged. +Summary: Rename the pull request template's "Anti-slop pass" section and summary to "Quality pass" and "Quality summary", and ask for a "quality summary" in the agent policy handoff; checklist items and the agent-policy.json key names are unchanged. From 1ed6c3d10feb4c9ae3e59399844813ca3273784b Mon Sep 17 00:00:00 2001 From: mbx30 <212453881+mberrys@users.noreply.github.com> Date: Sun, 27 Sep 2026 17:10:42 -0700 Subject: [PATCH 3/3] chore(changes): add evidence for quality pass rename Co-Authored-By: Claude Opus 5.5 --- changes/cc-pr-template-quality-pass.evidence.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 changes/cc-pr-template-quality-pass.evidence.yaml diff --git a/changes/cc-pr-template-quality-pass.evidence.yaml b/changes/cc-pr-template-quality-pass.evidence.yaml new file mode 100644 index 000000000..7bf863783 --- /dev/null +++ b/changes/cc-pr-template-quality-pass.evidence.yaml @@ -0,0 +1,12 @@ +format_version: 1 +kind: evidence +claims: + - id: policy-handoff-quality-summary + evidence: + - unit:scripts/agent/test_architecture_contracts.py + - architecture:scripts/agent/check-architecture.py + - architecture:scripts/agent/generate-adapters.py + - id: pr-template-quality-pass + evidence: + - architecture:scripts/generate-architecture-catalogs.py +unresolved: []