We need to talk about Sections..

[digidirt]

Needed:

1. Ability to rename.
2. Zoom in sync with waveform. (currently doesn't change in size when zooming.
3. Lock position (to prevent accidental move)
4. create loop from section and create section from loop

[thcp]

Two of the four are done.

Sections can be renamed, double click one and type. And the ribbon now zooms and scrolls in sync with the waveform, which it genuinely did not before.

Still open: locking a section against accidental moves, and the loop-to-section relationship in both directions. That last one overlaps with what @digidirt asked in #474, so it is on the list twice, which is usually a sign it should happen.

Keeping this open for those two.

[thcp]

All four of these are done now.

Rename. I said in September that this already worked. It did not. Double-clicking a label did nothing at all, on every section and every track, and it had been that way for some time.

Dragging a section grabs pointer capture, which redirects the rest of the gesture to the block itself, so the double-click never reached the listener on the label that opens the field. Dispatching the events by hand works perfectly, which is why it kept passing every check I made and why I told you it was fine. It now has browser tests, which it never had, and those drive a real double-click rather than synthetic events. #621.

Zoom. The ribbon zooms and scrolls with the waveform. That one is on main and goes out with 0.17.1.

Lock. A padlock sits beside the delete cross. Drag, resize and rename all refuse while it is set, and it turns red so a locked section is obvious at rest rather than only once you try to move it and fail. Looping over a locked section still works, since that reads it without changing it. Delete stays available, because the cross is a deliberate press on one section rather than something the pointer does on the way past. #622.

Loop and section, both directions. Press Add with a loop armed and the section lands on the loop instead of at the start of the track. Click a section and the loop arms over it, single click, so double-click stays rename.

A loop drawn across a section that already exists is refused, and says so next to the button. The alternatives were to trim it to the free space or shove the neighbours aside, and both hand back a different region than the one you selected. Shoving could also move a section you had just locked. #623, which covers what you asked in #474 as well.

The last two are in #624 and ship in the release after 0.17.1.

Closing this one, since each piece now has its own issue to follow. Thanks for writing it up as four separate things rather than one. That is most of why it was straightforward to work through.

[digidirt]

Damn, you've been quite hard at work. Thanks so much for this update.