[DRAFT] ingest: full-history ingestion for cold + hot stores (#765)#779
Draft
chowbao wants to merge 1 commit into
Draft
[DRAFT] ingest: full-history ingestion for cold + hot stores (#765)#779chowbao wants to merge 1 commit into
chowbao wants to merge 1 commit into
Conversation
Closed
4 tasks
View-based ingestion pipeline at internal/fullhistory/ingest: - HotIngester / ColdIngester interfaces over xdr.LedgerCloseMetaView. - Six ingesters (ledger/events/txhash x hot/cold) using the #764 view extractors; hot stores injected (daemon-owned), cold writers per-chunk. - Per-tier HotService (parallel per-LCM fan-out) / ColdService (sequential + Finalize), config-driven data-type selection. - MetricSink interface + Prometheus implementation (daemon convention); per-ingester + aggregate signals, emitted on success and failure paths. - ChunkSource abstraction: pack / GCS / S3 / any datastore, extensible. Hardening: drain validates per-ledger LedgerSequence; txhash cold .bin published atomically (tmp+rename); concurrency-safe txhash cold reader; failure-path + .bin-content tests. Bundles the txhash cold-store extraction (a #765 dependency). Closes #765.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #765 — the full-history ingestion path. Code at
cmd/stellar-rpc/internal/fullhistory/ingest/.Design (matches the issue)
HotIngester{Ingest(ctx, xdr.LedgerCloseMetaView)},ColdIngester{Ingest, Finalize, Close}.[]byte(lcm)verbatim.Finalizecommits,Closedrops partials).HotService(per-LCM parallel fan-out, waits-all),ColdService(sequential +Finalize), config-driven data-type selection.MetricSinkinterface +PrometheusSink(daemon convention). Per-ingester (hot per-ledger, cold per-chunk: latency/items/errors) + aggregate per-tier wall-clock — emitted on success and failure paths.ChunkSource—NewPackSource/NewGCSSource/NewS3Source/NewDataStoreSource(GCS/S3/FS unify via the SDK datastore; new backends implement one interface).Notes
-race.Test plan
go test ./cmd/stellar-rpc/internal/fullhistory/ingest/ ./cmd/stellar-rpc/internal/fullhistory/pkg/stores/txhash/(incl.-race)