chore: cleanup and fix bugs

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: gururaj1512

lib/node_modules/@stdlib/plot/vega/legend/ctor/lib/defaults.js

@@ -24,19 +24,20 @@
 * Returns defaults.
 *
 * @private
+* @param {string} direction - legend direction
 * @returns {Object} default options
 *
 * @example
-* var o = defaults();
+* var o = defaults( 'vertical' );
 * // returns {...}
 */
-function defaults() {
+function defaults( direction ) {
 	return {
 		// Boolean indicating whether to include ARIA attributes in SVG output:
 		'aria': true,
 
 		// Number of columns in which to arrange symbol legend entries:
-		'columns': 1,
+		'columns': ( direction === 'horizontal' ) ? 0 : 1,
 
 		// Direction of the legend:
 		'direction': 'vertical',
@@ -56,6 +57,9 @@ function defaults() {
 		// Legend orientation:
 		'orient': 'right',
 
+		// Stroke dash for legend symbols:
+		'symbolDash': [],
+
 		// Legend title:
 		'title': [ '' ],
 

lib/node_modules/@stdlib/plot/vega/legend/ctor/lib/format-type/get.js

@@ -28,7 +28,7 @@ var prop = require( './properties.js' );
 // MAIN //
 
 /**
-* Returns the format type.
+* Returns the format to use for legend scales which do not have a strict domain data type.
 *
 * @private
 * @returns {(string|void)} format type

lib/node_modules/@stdlib/plot/vega/legend/ctor/lib/format-type/set.js

@@ -40,7 +40,7 @@ var debug = logger( 'vega:legend:set:'+prop.name );
 // MAIN //
 
 /**
-* Sets the format type.
+* Sets the format to use for legend scales which do not have a strict domain data type.
 *
 * ## Notes
 *

lib/node_modules/@stdlib/plot/vega/legend/ctor/lib/format/get.js

@@ -22,6 +22,8 @@
 
 // MODULES //
 
+var isObject = require( '@stdlib/assert/is-object' );
+var objectAssignIn = require( '@stdlib/object/assign-in' );
 var prop = require( './properties.js' );
 
 
@@ -34,7 +36,8 @@ var prop = require( './properties.js' );
 * @returns {(string|Object|void)} format
 */
 function get() {
-	return this[ prop.private ];
+	var v = this[ prop.private ];
+	return ( isObject( v ) ) ? objectAssignIn( {}, v ) : v;
 }
 
 

lib/node_modules/@stdlib/plot/vega/legend/ctor/lib/format/set.js

@@ -26,6 +26,7 @@ var logger = require( 'debug' );
 var isString = require( '@stdlib/assert/is-string' ).isPrimitive;
 var isObject = require( '@stdlib/assert/is-object' );
 var isUndefined = require( '@stdlib/assert/is-undefined' );
+var objectAssignIn = require( '@stdlib/object/assign-in' );
 var format = require( '@stdlib/string/format' );
 var changeEvent = require( './../change_event.js' );
 var prop = require( './properties.js' );
@@ -51,12 +52,19 @@ var debug = logger( 'vega:legend:set:'+prop.name );
 * @returns {void}
 */
 function set( value ) {
-	if ( !isString( value ) && !isObject( value ) && !isUndefined( value ) ) {
-		throw new TypeError( format( 'invalid assignment. `%s` must be a string or object. Value: `%s`.', prop.name, value ) );
+	var isObj = isObject( value );
+
+	// FIXME: validate that an object is a valid TimeMultiFormat object
+
+	if ( !isString( value ) && !isObj && !isUndefined( value ) ) {
+		throw new TypeError( format( 'invalid assignment. `%s` must be a string or a valid format object. Value: `%s`.', prop.name, value ) );
 	}
+
+	// TODO: consider a deep equality check for format objects in order to avoid false positive change events
+
 	if ( value !== this[ prop.private ] ) {
-		debug( 'Current value: %s. New value: %s.', this[ prop.private ], value );
-		this[ prop.private ] = value;
+		debug( 'Current value: %s. New value: %s.', JSON.stringify( this[ prop.private ] ), JSON.stringify( value ) );
+		this[ prop.private ] = ( isObj ) ? objectAssignIn( {}, value ) : value;
 		this.emit( 'change', changeEvent( prop.name ) );
 	}
 }

lib/node_modules/@stdlib/plot/vega/legend/ctor/lib/gradient-length/get.js

@@ -28,7 +28,7 @@ var prop = require( './properties.js' );
 // MAIN //
 
 /**
-* Returns the length (in pixels) of the color ramp in a gradient legend.
+* Returns the length (in pixels) of the primary axis of a color gradient.
 *
 * @private
 * @returns {(number|void)} gradient length

lib/node_modules/@stdlib/plot/vega/legend/ctor/lib/gradient-length/set.js

@@ -38,7 +38,7 @@ var debug = logger( 'vega:legend:set:'+prop.name );
 // MAIN //
 
 /**
-* Sets the length (in pixels) of the color ramp in a gradient legend.
+* Sets the length (in pixels) of the primary axis of a color gradient.
 *
 * ## Notes
 *

lib/node_modules/@stdlib/plot/vega/legend/ctor/lib/gradient-stroke-color/get.js

@@ -28,7 +28,7 @@ var prop = require( './properties.js' );
 // MAIN //
 
 /**
-* Returns the stroke color of the color ramp border.
+* Returns the stroke color of the color gradient border.
 *
 * @private
 * @returns {(string|void)} gradient stroke color

lib/node_modules/@stdlib/plot/vega/legend/ctor/lib/gradient-stroke-color/set.js

@@ -38,7 +38,7 @@ var debug = logger( 'vega:legend:set:'+prop.name );
 // MAIN //
 
 /**
-* Sets the stroke color of the color ramp border.
+* Sets the stroke color of the color gradient border.
 *
 * ## Notes
 *

lib/node_modules/@stdlib/plot/vega/legend/ctor/lib/gradient-stroke-width/get.js

@@ -28,7 +28,7 @@ var prop = require( './properties.js' );
 // MAIN //
 
 /**
-* Returns the stroke width of the color ramp border.
+* Returns the stroke width of the color gradient border.
 *
 * @private
 * @returns {(number|void)} gradient stroke width