Remove feature mod_builtin

Author: OmriEshhar1

.github/workflows/rust.yml

@@ -294,7 +294,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        special_features: ["", "extensive_hints", "mod_builtin", "cairo-0-secp-hints", "cairo-0-data-availability-hints"]
+        special_features: ["", "extensive_hints", "cairo-0-secp-hints", "cairo-0-data-availability-hints"]
         target: [ test#1, test#2, test#3, test#4 ]
     name: Run tests
     runs-on: ubuntu-24.04
@@ -542,30 +542,6 @@ jobs:
         path: lcov-test#4-extensive_hints.info
         key: codecov-cache-test#4-extensive_hints-${{ github.sha }}
         fail-on-cache-miss: true
-    - name: Fetch results for tests with stdlib (w/mod_builtin; part. 1)
-      uses: actions/cache/restore@v3
-      with:
-        path: lcov-test#1-mod_builtin.info
-        key: codecov-cache-test#1-mod_builtin-${{ github.sha }}
-        fail-on-cache-miss: true
-    - name: Fetch results for tests with stdlib (w/mod_builtin; part. 2)
-      uses: actions/cache/restore@v3
-      with:
-        path: lcov-test#2-mod_builtin.info
-        key: codecov-cache-test#2-mod_builtin-${{ github.sha }}
-        fail-on-cache-miss: true
-    - name: Fetch results for tests with stdlib (w/mod_builtin; part. 3)
-      uses: actions/cache/restore@v3
-      with:
-        path: lcov-test#3-mod_builtin.info
-        key: codecov-cache-test#3-mod_builtin-${{ github.sha }}
-        fail-on-cache-miss: true
-    - name: Fetch results for tests with stdlib (w/mod_builtin; part. 4)
-      uses: actions/cache/restore@v3
-      with:
-        path: lcov-test#4-mod_builtin.info
-        key: codecov-cache-test#4-mod_builtin-${{ github.sha }}
-        fail-on-cache-miss: true
     - name: Fetch results for tests with stdlib (w/cairo-0-secp-hints; part. 1)
       uses: actions/cache/restore@v3
       with:

CHANGELOG.md

@@ -11,13 +11,16 @@ Both branches support Stwo prover opcodes (Blake2s, QM31) since v2.0.0.
 ---
 
 #### Upcoming Changes
+* fix: remove feature mod_builtin [#2387](https://github.com/starkware-libs/cairo-vm/pull/2387)
+
 * fix: decrease spamming logs level to trace [#2385](https://github.com/starkware-libs/cairo-vm/pull/2385)
 
 * feat: add `test_helpers` module (`error_utils`, `test_utils`) with `assert_mr_eq`, `load_cairo_program!` macro and `expect_*` error checkers, behind `test_utils` feature flag [#2381](https://github.com/starkware-libs/cairo-vm/pull/2381)
 
 * feat(makefile,ci): add `cairo_test_suite_programs` Makefile target and CI integration to compile Cairo test suite programs before running tests [#2380](https://github.com/starkware-libs/cairo-vm/pull/2380)
 
 * Add Stwo cairo runner API [#2351](https://github.com/starkware-libs/cairo-vm/pull/2351)
+
 * feat: make max traceback entries configurable [#2370](https://github.com/starkware-libs/cairo-vm/pull/2370)
 
 * feat: create and use VirtualMachineConfig [#2369](https://github.com/starkware-libs/cairo-vm/pull/2369)

cairo-vm-cli/Cargo.toml

@@ -22,4 +22,3 @@ rstest = "0.17.0"
 default = ["with_mimalloc"]
 with_mimalloc = ["dep:mimalloc"]
 with_tracer = ["cairo-vm/tracer", "cairo-vm-tracer"]
-mod_builtin = ["cairo-vm/mod_builtin"]

cairo1-run/Cargo.toml

@@ -26,9 +26,6 @@ rstest = "0.17.0"
 num-traits = { version = "0.2", default-features = false }
 num-bigint.workspace = true
 
-[features]
-mod_builtin = ["cairo-vm/mod_builtin"]
-
 [[bin]]
 name = "cairo1-run"
 path = "./src/main.rs"

cairo1-run/Makefile

@@ -3,10 +3,10 @@
 CAIRO_1_FOLDER=../cairo_programs/cairo-1-programs
 
 $(CAIRO_1_FOLDER)/%.trace: $(CAIRO_1_FOLDER)/%.cairo
-	cargo run --release -F mod_builtin $< --trace_file $@ --layout all_cairo
+	cargo run --release $< --trace_file $@ --layout all_cairo
 
 $(CAIRO_1_FOLDER)/%.memory: $(CAIRO_1_FOLDER)/%.cairo
-	cargo run --release -F mod_builtin $< --memory_file $@ --layout all_cairo
+	cargo run --release $< --memory_file $@ --layout all_cairo
 
 CAIRO_1_PROGRAMS=$(wildcard ../cairo_programs/cairo-1-programs/*.cairo)
 TRACES:=$(patsubst $(CAIRO_1_FOLDER)/%.cairo, $(CAIRO_1_FOLDER)/%.trace, $(CAIRO_1_PROGRAMS))

cairo1-run/README.md

@@ -71,10 +71,6 @@ The cairo1-run cli supports the following optional arguments:
 
 * `--append_return_values`: Adds extra instructions to the program in order to append the return and input values to the output builtin's segment. This is the default behaviour for proof_mode. Only allows `Array<felt252>` as return and input value.
 
-## Running circuits
-
-Circuits in cairo 1 require to enable the `mod_builtin` feature in order for the `AddMod`, `MulMod` and `RangeCheck96` builtins to be taken into account.
-
 # Running scarb projects
 
 As cairo1-run skips gas checks when running, you will need to add the following to your Scarb.toml to ensure that compilation is done without adding gas checks:

cairo1-run/src/main.rs

@@ -408,13 +408,13 @@ mod tests {
         Some("[17 18]"),
         Some("[17 18]")
     )]
-    #[cfg_attr(feature = "mod_builtin", case(
+    #[case(
         "circuit.cairo",
         "36699840570117848377038274035 72042528776886984408017100026 54251667697617050795983757117 7",
         "[36699840570117848377038274035 72042528776886984408017100026 54251667697617050795983757117 7]",
         None,
         None
-    ))]
+    )]
     #[case(
         "gas_builtin_loading.cairo",
         "939340725154356279478212603733403581890242362232206720294887278547043341575",

docs/onboarding.md

@@ -41,7 +41,6 @@ The `vm` crate has several feature flags that control compilation:
 
 - `std` (default) — Standard library support. Disable for `no_std`/WASM targets.
 - `cairo-1-hints` — Enables the Cairo 1 hint processor. Pulls in `cairo-lang-casm` and ark dependencies.
-- `mod_builtin` — Enables the modular arithmetic builtin.
 - `cairo-0-secp-hints` — Enables secp256k1/secp256r1 hint implementations for Cairo 0.
 - `cairo-0-data-availability-hints` — Enables data availability-related hints for Cairo 0.
 - `extensive_hints` — Allows extending the hint set at runtime from within a hint.

vm/Cargo.toml

@@ -16,7 +16,6 @@ cairo-1-hints = [
     "dep:ark-std",
 ]
 tracer = []
-mod_builtin = []
 cairo-0-secp-hints = []
 cairo-0-data-availability-hints = []
 

vm/src/cairo_run.rs

@@ -758,19 +758,17 @@ mod tests {
     }
 
     fn stwo_allowed_builtins() -> Vec<BuiltinName> {
-        let mut allowed = vec![
+        let allowed = vec![
             BuiltinName::output,
             BuiltinName::pedersen,
             BuiltinName::range_check,
             BuiltinName::bitwise,
             BuiltinName::ec_op,
             BuiltinName::poseidon,
             BuiltinName::range_check96,
+            BuiltinName::add_mod,
+            BuiltinName::mul_mod,
         ];
-        if cfg!(feature = "mod_builtin") {
-            allowed.push(BuiltinName::add_mod);
-            allowed.push(BuiltinName::mul_mod);
-        }
         allowed
     }