Merge pull request #7389 from rob-stacks/feat/costs_5_from_valgrind_bench_tool

updated costs_5

Author: brice-stacks

changelog.d/costs-5-valgrind-calibration.changed

@@ -0,0 +1 @@
+Recalibrated all Clarity 6 (Epoch 4.0) runtime cost functions in `costs_5.rs` using Callgrind instruction-count measurements from `clarity-cost-bench`. Arithmetic, tuple, sequence, hash, crypto, and store operations now have bench-derived linear formulas instead of forwarding to the Clarity 4 values, with a calibration baseline of 1 cost unit = 80,000 CPU instructions (a clean round value chosen to place the base overhead of any Clarity call at ≈38 units).

clarity/src/vm/costs/costs_5.rs

@@ -988,7 +988,18 @@ impl TrackerData {
             let cost_function_ref = cost_function_references.remove(f).unwrap_or_else(|| {
                 ClarityCostFunctionReference::new(boot_costs_id.clone(), f.get_name())
             });
-            if !cost_contracts.contains_key(&cost_function_ref.contract_id) {
+
+            let is_boot_default = cost_function_ref.contract_id == boot_costs_id;
+
+            // Beginning in epoch 4.0 the costs are implemented in Rust only,
+            // and not deployed on-chain in a contract. This is possible with
+            // the disabling of cost-voting.
+            let requires_contract_load =
+                !is_boot_default || epoch_id.supports_cost_voting_contract();
+
+            if requires_contract_load
+                && !cost_contracts.contains_key(&cost_function_ref.contract_id)
+            {
                 let contract = match clarity_db.get_contract(&cost_function_ref.contract_id) {
                     Ok(contract) => contract,
                     Err(e) => {
@@ -1004,7 +1015,7 @@ impl TrackerData {
                 cost_contracts.insert(cost_function_ref.contract_id.clone(), contract);
             }
 
-            if cost_function_ref.contract_id == boot_costs_id {
+            if is_boot_default {
                 m.insert(
                     f,
                     ClarityCostFunctionEvaluator::Default(cost_function_ref, f.clone(), v),

clarity/src/vm/costs/mod.rs

@@ -52,8 +52,8 @@ use stackslib::burnchains::{PoxConstants, Txid};
 use stackslib::chainstate::stacks::boot::{
     BOOT_CODE_BNS, BOOT_CODE_COST_VOTING_MAINNET, BOOT_CODE_COST_VOTING_TESTNET, BOOT_CODE_COSTS,
     BOOT_CODE_COSTS_2, BOOT_CODE_COSTS_2_TESTNET, BOOT_CODE_COSTS_3, BOOT_CODE_COSTS_4,
-    BOOT_CODE_COSTS_5, BOOT_CODE_GENESIS, BOOT_CODE_LOCKUP, BOOT_CODE_POX_MAINNET,
-    BOOT_CODE_POX_TESTNET, POX_2_MAINNET_CODE, POX_2_TESTNET_CODE,
+    BOOT_CODE_GENESIS, BOOT_CODE_LOCKUP, BOOT_CODE_POX_MAINNET, BOOT_CODE_POX_TESTNET,
+    POX_2_MAINNET_CODE, POX_2_TESTNET_CODE,
 };
 use stackslib::chainstate::stacks::index::ClarityMarfTrieId;
 use stackslib::clarity_vm::clarity::{ClarityMarfStore, ClarityMarfStoreTransaction};
@@ -64,7 +64,7 @@ use stackslib::util_lib::boot::{boot_code_addr, boot_code_id};
 use stackslib::util_lib::db::{FromColumn, sqlite_open};
 
 lazy_static! {
-    pub static ref STACKS_BOOT_CODE_MAINNET_2_1: [(&'static str, &'static str); 11] = [
+    pub static ref STACKS_BOOT_CODE_MAINNET_2_1: [(&'static str, &'static str); 10] = [
         ("pox", &BOOT_CODE_POX_MAINNET),
         ("lockup", BOOT_CODE_LOCKUP),
         ("costs", BOOT_CODE_COSTS),
@@ -75,9 +75,8 @@ lazy_static! {
         ("pox-2", &POX_2_MAINNET_CODE),
         ("costs-3", BOOT_CODE_COSTS_3),
         ("costs-4", BOOT_CODE_COSTS_4),
-        ("costs-5", BOOT_CODE_COSTS_5),
     ];
-    pub static ref STACKS_BOOT_CODE_TESTNET_2_1: [(&'static str, &'static str); 11] = [
+    pub static ref STACKS_BOOT_CODE_TESTNET_2_1: [(&'static str, &'static str); 10] = [
         ("pox", &BOOT_CODE_POX_TESTNET),
         ("lockup", BOOT_CODE_LOCKUP),
         ("costs", BOOT_CODE_COSTS),
@@ -88,7 +87,6 @@ lazy_static! {
         ("pox-2", &POX_2_TESTNET_CODE),
         ("costs-3", BOOT_CODE_COSTS_3),
         ("costs-4", BOOT_CODE_COSTS_4),
-        ("costs-5", BOOT_CODE_COSTS_5),
     ];
 }