Skip to content

Commit 905ff63

Browse files
committed
add missing env vars to buildpack task in concourse
1 parent 9607fbd commit 905ff63

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

.e2e/buildpack/concourse.expected.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,11 @@ jobs:
4848
--env ARTIFACTORY_PASSWORD \
4949
--env ARTIFACTORY_URL \
5050
--env ARTIFACTORY_USERNAME \
51+
--env BUILD_VERSION \
5152
--env CI \
5253
--env EAID \
5354
--env EE_PLATFORM_TEAM \
55+
--env GIT_REVISION \
5456
--env RUNNING_IN_CI \
5557
--publish \
5658
--trust-builder
@@ -64,9 +66,11 @@ jobs:
6466
--env ARTIFACTORY_PASSWORD \
6567
--env ARTIFACTORY_URL \
6668
--env ARTIFACTORY_USERNAME \
69+
--env BUILD_VERSION \
6770
--env CI \
6871
--env EAID \
6972
--env EE_PLATFORM_TEAM \
73+
--env GIT_REVISION \
7074
--env RUNNING_IN_CI \
7175
--publish \
7276
--trust-builder
@@ -131,9 +135,11 @@ jobs:
131135
--env ARTIFACTORY_USERNAME \
132136
--env BP_BAR \
133137
--env BP_FOO \
138+
--env BUILD_VERSION \
134139
--env CI \
135140
--env EAID \
136141
--env EE_PLATFORM_TEAM \
142+
--env GIT_REVISION \
137143
--env RUNNING_IN_CI \
138144
--publish \
139145
--trust-builder
@@ -150,9 +156,11 @@ jobs:
150156
--env ARTIFACTORY_USERNAME \
151157
--env BP_BAR \
152158
--env BP_FOO \
159+
--env BUILD_VERSION \
153160
--env CI \
154161
--env EAID \
155162
--env EE_PLATFORM_TEAM \
163+
--env GIT_REVISION \
156164
--env RUNNING_IN_CI \
157165
--publish \
158166
--trust-builder

renderers/concourse/buildpack.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,11 @@ func packScriptArgs(task manifest.Buildpack, man manifest.Manifest, basePath str
9090
appPath = task.Path
9191
}
9292

93+
envKeys := slices.AppendSeq([]string{"BUILD_VERSION", "GIT_REVISION"}, maps.Keys(task.Vars))
94+
slices.Sort(envKeys)
95+
9396
var envVars strings.Builder
94-
for _, key := range slices.Sorted(maps.Keys(task.Vars)) {
97+
for _, key := range envKeys {
9598
envVars.WriteString(fmt.Sprintf(`--env %s \
9699
`, key))
97100
}

0 commit comments

Comments
 (0)