Add cache directives to routes with safe caching patterns

- Public key endpoints cache for 5 minutes (CACHE_SHORT_PRIVATE)
- Immutable media blobs cache for 1 year (CACHE_IMMUTABLE_PRIVATE)
- Public testimonials cache for 60 seconds (CACHE_SHORT_PUBLIC)
- All other routes default to no-store

Author: Chris Jensen

services/media/src/routes/media.routes.ts

@@ -9,6 +9,7 @@ import {
   NotFoundError,
   ValidationError,
 } from '@speakeasy-services/common';
+import { CACHE_IMMUTABLE_PRIVATE } from '@speakeasy-services/service-base';
 
 type Response = Parameters<RequestHandler>[1];
 import {
@@ -125,6 +126,7 @@ const methodHandlers = {
 
     const stream = await getFromS3(key);
     res.setHeader('Content-Type', record.mimeType);
+    res.setHeader('Cache-Control', CACHE_IMMUTABLE_PRIVATE);
     res.status(200);
     await pipeline(stream, res);
 

services/service-admin/src/routes/testimonials.routes.ts

@@ -9,6 +9,7 @@ import {
   ValidationError,
   validateAgainstLexicon,
 } from '@speakeasy-services/common';
+import { CACHE_SHORT_PUBLIC } from '@speakeasy-services/service-base';
 import {
   checkContributionDef,
   createTestimonialDef,
@@ -190,12 +191,16 @@ const methodHandlers = {
 } as const;
 
 // Define methods using XRPC lexicon
-export const methods: Record<MethodName, { handler: RequestHandler }> = {
+export const methods: Record<
+  MethodName,
+  { handler: RequestHandler; cacheControl?: string }
+> = {
   'social.spkeasy.actor.createTestimonial': {
     handler: methodHandlers['social.spkeasy.actor.createTestimonial'],
   },
   'social.spkeasy.actor.listTestimonials': {
     handler: methodHandlers['social.spkeasy.actor.listTestimonials'],
+    cacheControl: CACHE_SHORT_PUBLIC,
   },
   'social.spkeasy.actor.updateTestimonial': {
     handler: methodHandlers['social.spkeasy.actor.updateTestimonial'],

services/user-keys/src/routes/key.routes.ts

@@ -14,6 +14,7 @@ import {
   User,
   getSessionDid,
 } from '@speakeasy-services/common';
+import { CACHE_SHORT_PRIVATE } from '@speakeasy-services/service-base';
 import {
   getPublicKeyDef,
   getPrivateKeysDef,
@@ -153,12 +154,17 @@ const methodHandlers = {
 
 type MethodName = keyof typeof methodHandlers;
 
-export const methods: Record<MethodName, { handler: RequestHandler }> = {
+export const methods: Record<
+  MethodName,
+  { handler: RequestHandler; cacheControl?: string }
+> = {
   'social.spkeasy.key.getPublicKey': {
     handler: methodHandlers['social.spkeasy.key.getPublicKey'],
+    cacheControl: CACHE_SHORT_PRIVATE,
   },
   'social.spkeasy.key.getPublicKeys': {
     handler: methodHandlers['social.spkeasy.key.getPublicKeys'],
+    cacheControl: CACHE_SHORT_PRIVATE,
   },
   'social.spkeasy.key.getPrivateKey': {
     handler: methodHandlers['social.spkeasy.key.getPrivateKey'],