PFC Watchdog Allows Invalid Configuration where Polling Interval Exceeds Detection Time

[abhishek-nexthop]

Description

When configuring the PFC watchdog, it is possible to set the polling interval first and then enable the watchdog on an interface with a detection time lower than the configured interval. The configuration is accepted and applied successfully, even though this violates the expected constraint that the polling interval must not exceed the minimum detection time across interfaces.

Error

No explicit error is reported. The configuration is accepted without validation failure.

Root Cause

There is no validation logic enforcing the relationship between the global PFC watchdog polling interval and per-interface detection times. As a result, configurations where the polling interval is greater than the smallest detection time are allowed and applied.

Steps to Reproduce

• Set the PFC watchdog polling interval to a higher value.
• Configure and enable PFC watchdog on an interface with a detection time lower than the configured interval.
• Observe that the configuration is accepted without error.

Expected Behavior

The system should reject configurations where the PFC watchdog polling interval is greater than the minimum detection time across all interfaces. An appropriate validation error should be returned.

Actual Behavior

The configuration is accepted and applied successfully, even though the polling interval exceeds the detection time, resulting in an invalid setup.

[Bojun-Feng]

Hi @abhishek-nexthop, I looked into this issue, seems like both detection time / restoration time are missing checks in the CLI. Additionally, the existing unit tests were using detection/restoration values below POLL_INTERVAL.

Made a PR to address this, would appreciate your review when you're available.