fix: URL to path conversion in manifest resolver

Author: silen-z

.changeset/brown-mice-train.md

@@ -0,0 +1,5 @@
+---
+"@solidjs/start": patch
+---
+
+Fix URL to path conversion in manifest resolver

packages/start/src/config/manifest.ts

@@ -1,6 +1,7 @@
 import fs from "node:fs";
 import path from "node:path";
 import { type PluginOption, type ViteDevServer, version as viteVersion } from "vite";
+import { fileURLToPath } from "node:url";
 
 import { findStylesInModuleGraph } from "../server/collect-styles.ts";
 import { VIRTUAL_MODULES } from "./constants.ts";
@@ -20,12 +21,16 @@ export function manifest(start: SolidStartOptions): PluginOption {
         return `\0${VIRTUAL_MODULES.clientViteManifest}`;
       if (id === VIRTUAL_MODULES.getClientManifest)
         return this.resolve(
-          new URL("../server/manifest/client-manifest", import.meta.url).pathname,
+          fileURLToPath(new URL("../server/manifest/client-manifest", import.meta.url)),
         );
       if (id === VIRTUAL_MODULES.getManifest) {
         return this.environment.config.consumer === "client"
-          ? this.resolve(new URL("../server/manifest/client-manifest", import.meta.url).pathname)
-          : this.resolve(new URL("../server/manifest/ssr-manifest", import.meta.url).pathname);
+          ? this.resolve(
+              fileURLToPath(new URL("../server/manifest/client-manifest", import.meta.url)),
+            )
+          : this.resolve(
+              fileURLToPath(new URL("../server/manifest/ssr-manifest", import.meta.url)),
+            );
       }
       if (id === VIRTUAL_MODULES.middleware) {
         if (start.middleware) return await this.resolve(start.middleware);
@@ -44,28 +49,35 @@ export function manifest(start: SolidStartOptions): PluginOption {
           if (!entry) throw new Error("No client entry found");
           let rawManifest: string | undefined;
 
-          const viteMajor = parseInt(viteVersion.split('.')[0]!, 10);
+          const viteMajor = parseInt(viteVersion.split(".")[0]!, 10);
 
-          const manifestKey = Object.keys(globalThis.START_CLIENT_BUNDLE).find(k => k.endsWith("manifest.json"));
+          const manifestKey = Object.keys(globalThis.START_CLIENT_BUNDLE).find(k =>
+            k.endsWith("manifest.json"),
+          );
           if (manifestKey && viteMajor < 8) {
             const manifestAsset = globalThis.START_CLIENT_BUNDLE[manifestKey] as any;
             rawManifest = manifestAsset.source as string;
           } else {
-             try {
-               const appRoot = (start as any).appRoot || "./src";
-               let outDir = ".solid-start/client";
-               if (devServer?.environments?.client?.config?.build?.outDir) {
-                 outDir = devServer.environments.client.config.build.outDir;
-               } else if (this.environment?.config?.build?.outDir && this.environment?.config?.consumer === "client") {
-                 outDir = this.environment.config.build.outDir;
-               } else if ((globalThis as any).START_CLIENT_OUT_DIR) {
-                 outDir = (globalThis as any).START_CLIENT_OUT_DIR;
-               }
-               const manifestPath = path.resolve(appRoot, "..", outDir, ".vite/manifest.json");
-               rawManifest = fs.readFileSync(manifestPath, "utf-8");
-             } catch (e) {
-               throw new Error(`Manifest asset not found in bundle and could not be read from disk. Keys: ${Object.keys(globalThis.START_CLIENT_BUNDLE).join(", ")}. Error: ${e}`);
-             }
+            try {
+              const appRoot = (start as any).appRoot || "./src";
+              let outDir = ".solid-start/client";
+              if (devServer?.environments?.client?.config?.build?.outDir) {
+                outDir = devServer.environments.client.config.build.outDir;
+              } else if (
+                this.environment?.config?.build?.outDir &&
+                this.environment?.config?.consumer === "client"
+              ) {
+                outDir = this.environment.config.build.outDir;
+              } else if ((globalThis as any).START_CLIENT_OUT_DIR) {
+                outDir = (globalThis as any).START_CLIENT_OUT_DIR;
+              }
+              const manifestPath = path.resolve(appRoot, "..", outDir, ".vite/manifest.json");
+              rawManifest = fs.readFileSync(manifestPath, "utf-8");
+            } catch (e) {
+              throw new Error(
+                `Manifest asset not found in bundle and could not be read from disk. Keys: ${Object.keys(globalThis.START_CLIENT_BUNDLE).join(", ")}. Error: ${e}`,
+              );
+            }
           }
 
           if (!rawManifest) {