Apply review suggestions

Author: franciszekjob

starknet_py/net/client_models.py

@@ -640,6 +640,10 @@ class StarknetBlockWithTxHashes(BlockHeader):
 
 
 class TransactionResponseFlag(str, Enum):
+    """
+    Flags that control what additional fields are included in the transaction response.
+    """
+
     INCLUDE_PROOF_FACTS = "INCLUDE_PROOF_FACTS"
 
 

starknet_py/net/full_node_client.py

@@ -153,7 +153,8 @@ async def get_block_with_txs(
         )
 
         params = {**block_identifier}
-        if response_flags is not None:
+
+        if response_flags:
             params["response_flags"] = response_flags
 
         res = await self._client.call(
@@ -202,7 +203,8 @@ async def get_block_with_receipts(
         )
 
         params = {**block_identifier}
-        if response_flags is not None:
+
+        if response_flags:
             params["response_flags"] = response_flags
 
         res = await self._client.call(
@@ -379,14 +381,18 @@ async def get_storage_at(
             "key": _to_storage_key(key),
             **block_identifier,
         }
-        if response_flags is not None:
+
+        if response_flags:
             params["response_flags"] = response_flags
 
         res = await self._client.call(
             method_name="getStorageAt",
             params=params,
         )
-        if isinstance(res, dict):
+        if (
+            response_flags
+            and StorageResponseFlag.INCLUDE_LAST_UPDATE_BLOCK in response_flags
+        ):
             return cast(StorageResult, StorageResultSchema().load(res))
         res = cast(str, res)
         return int(res, 16)
@@ -453,7 +459,7 @@ async def get_transaction(
         try:
             params: dict = {"transaction_hash": _to_rpc_felt(tx_hash)}
 
-            if response_flags is not None:
+            if response_flags:
                 params["response_flags"] = response_flags
 
             res = await self._client.call(
@@ -735,7 +741,8 @@ async def get_transaction_by_block_id(
             **block_identifier,
             "index": index,
         }
-        if response_flags is not None:
+
+        if response_flags:
             params["response_flags"] = response_flags
 
         res = await self._client.call(

starknet_py/net/schemas/rpc/transactions.py

@@ -190,7 +190,7 @@ def make_transaction(self, data, **kwargs) -> InvokeTransactionV3:
 
 
 class BroadcastedInvokeTransactionV3Schema(InvokeTransactionV3Schema):
-    proof = fields.String(data_key="proof", load_default=None)
+    proof = fields.String(data_key="proof", required=False)
 
     @post_dump
     def remove_none_proof_fields(self, data, **kwargs):