Skip to content

Commit d4e5f85

Browse files
committed
chore: extract DefaultMetricCardinalityLimit to avoid duplicate literal
1 parent 8fc8c4e commit d4e5f85

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

pkg/beholder/config.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ type Config struct {
4141
MetricRetryConfig *RetryConfig
4242
MetricViews []metric.View
4343
// MetricCardinalityLimit sets the SDK per-instrument attribute-set limit (0 = disabled).
44-
// DefaultConfig uses 100000 as a production safety valve for high-cardinality workloads.
44+
// DefaultConfig uses DefaultMetricCardinalityLimit as a production safety valve for high-cardinality workloads.
4545
MetricCardinalityLimit int
4646
// MetricCompressor sets the gRPC compressor for metrics. Valid values: "gzip" (default), "none".
4747
MetricCompressor string
@@ -111,6 +111,9 @@ var defaultRetryConfig = RetryConfig{
111111
const (
112112
defaultPackageName = "beholder"
113113
defaultMaxConcurrentSends = 10
114+
115+
// DefaultMetricCardinalityLimit is the production safety valve for high-cardinality workloads.
116+
DefaultMetricCardinalityLimit = 100000
114117
)
115118

116119
var defaultOtelAttributes = []attribute.KeyValue{
@@ -142,7 +145,7 @@ func DefaultConfig() Config {
142145
// Metric
143146
MetricReaderInterval: 1 * time.Second,
144147
MetricCompressor: "gzip",
145-
MetricCardinalityLimit: 100000,
148+
MetricCardinalityLimit: DefaultMetricCardinalityLimit,
146149
// OTel metric exporter retry config
147150
MetricRetryConfig: defaultRetryConfig.Copy(),
148151
// Log

pkg/loop/config.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
"github.com/hashicorp/go-plugin"
1212
"go.uber.org/zap/zapcore"
1313

14+
"github.com/smartcontractkit/chainlink-common/pkg/beholder"
1415
"github.com/smartcontractkit/chainlink-common/pkg/config"
1516
"github.com/smartcontractkit/chainlink-common/pkg/settings/cresettings"
1617
)
@@ -548,7 +549,7 @@ func (e *EnvConfig) parse() error {
548549
}
549550
e.TelemetryMetricCardinalityLimit = &limit
550551
} else {
551-
defaultLimit := 100000
552+
defaultLimit := beholder.DefaultMetricCardinalityLimit
552553
e.TelemetryMetricCardinalityLimit = &defaultLimit
553554
}
554555
e.TelemetryPrometheusBridgeEnabled, err = getBool(envTelemetryPrometheusBridgeEnabled)

0 commit comments

Comments
 (0)