Skip to content

Commit 64ef3eb

Browse files
albertoabellagarciaalbertoabellagarcia
committed
review(dataModel.OpenStreetMap): batch validation run 20260522_0200
Status: READY (19/19 models) Tests: 12/12 passed for all models Models reviewed: OSMAeroway, OSMBarrier, OSMBoundary, OSMClub, OSMCraft, OSMEmergency, OSMGeological, OSMHealthcare, OSMHistoric, OSMIndoor, OSMManMade, OSMMilitary, OSMOffice, OSMPlace, OSMPower, OSMRoute, OSMTelecom, OSMTrafficSign, OSMWater Auto-fixes applied to all 19: - Scaffolded ADOPTERS.yaml and notes.yaml Auto-fixes applied to 15 models (all except OSMClub/Healthcare/Indoor/TrafficSign): - Regenerated example.jsonld (+@context), example-normalized.json (NGSIv2), example-normalized.jsonld (NGSI-LD) Auto-fixes applied to 5 models (Aeroway/Emergency/Historic/ManMade/Power): - Added required: [id, type] to schema.json See individual recommendations_20260522_0200.md files for full details.
1 parent 2ee9712 commit 64ef3eb

107 files changed

Lines changed: 2963 additions & 694 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎dataModel.OpenStreetMap/OSMAeroway/ADOPTERS.yaml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
---

‎dataModel.OpenStreetMap/OSMAeroway/examples/example-normalized.json‎

Lines changed: 59 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,66 @@
11
{
22
"id": "urn:ngsi-ld:OSMAeroway:way:123123123",
33
"type": "OSMAeroway",
4-
"osmId": 123123123,
5-
"osmType": "way",
6-
"osmLastModified": "2024-03-12T08:00:00Z",
7-
"name": "Adolfo Suárez Madrid-Barajas Pista 36L/18R",
8-
"aerowayType": "runway",
9-
"surface": "asphalt",
10-
"ref": "36L/18R",
11-
"lengthMeters": 4350.0,
12-
"widthMeters": 60.0,
4+
"osmId": {
5+
"type": "Integer",
6+
"value": 123123123
7+
},
8+
"osmType": {
9+
"type": "Text",
10+
"value": "way"
11+
},
12+
"osmLastModified": {
13+
"type": "DateTime",
14+
"value": "2024-03-12T08:00:00Z"
15+
},
16+
"name": {
17+
"type": "Text",
18+
"value": "Adolfo Suárez Madrid-Barajas Pista 36L/18R"
19+
},
20+
"aerowayType": {
21+
"type": "Text",
22+
"value": "runway"
23+
},
24+
"surface": {
25+
"type": "Text",
26+
"value": "asphalt"
27+
},
28+
"ref": {
29+
"type": "Text",
30+
"value": "36L/18R"
31+
},
32+
"lengthMeters": {
33+
"type": "Number",
34+
"value": 4350.0
35+
},
36+
"widthMeters": {
37+
"type": "Number",
38+
"value": 60.0
39+
},
1340
"location": {
14-
"type": "LineString",
15-
"coordinates": [
16-
[
17-
-3.5786,
18-
40.4851
19-
],
20-
[
21-
-3.5784,
22-
40.5244
41+
"type": "geo:json",
42+
"value": {
43+
"type": "LineString",
44+
"coordinates": [
45+
[
46+
-3.5786,
47+
40.4851
48+
],
49+
[
50+
-3.5784,
51+
40.5244
52+
]
2353
]
24-
]
54+
}
55+
},
56+
"source": {
57+
"type": "URL",
58+
"value": "https://www.openstreetmap.org"
2559
},
26-
"source": "https://www.openstreetmap.org",
27-
"seeAlso": [
28-
"https://www.openstreetmap.org/way/123123123"
29-
]
60+
"seeAlso": {
61+
"type": "StructuredValue",
62+
"value": [
63+
"https://www.openstreetmap.org/way/123123123"
64+
]
65+
}
3066
}

‎dataModel.OpenStreetMap/OSMAeroway/examples/example-normalized.jsonld‎

Lines changed: 60 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,69 @@
11
{
22
"id": "urn:ngsi-ld:OSMAeroway:way:123123123",
33
"type": "OSMAeroway",
4-
"osmId": 123123123,
5-
"osmType": "way",
6-
"osmLastModified": "2024-03-12T08:00:00Z",
7-
"name": "Adolfo Suárez Madrid-Barajas Pista 36L/18R",
8-
"aerowayType": "runway",
9-
"surface": "asphalt",
10-
"ref": "36L/18R",
11-
"lengthMeters": 4350.0,
12-
"widthMeters": 60.0,
4+
"osmId": {
5+
"type": "Property",
6+
"value": 123123123
7+
},
8+
"osmType": {
9+
"type": "Property",
10+
"value": "way"
11+
},
12+
"osmLastModified": {
13+
"type": "Property",
14+
"value": "2024-03-12T08:00:00Z"
15+
},
16+
"name": {
17+
"type": "Property",
18+
"value": "Adolfo Suárez Madrid-Barajas Pista 36L/18R"
19+
},
20+
"aerowayType": {
21+
"type": "Property",
22+
"value": "runway"
23+
},
24+
"surface": {
25+
"type": "Property",
26+
"value": "asphalt"
27+
},
28+
"ref": {
29+
"type": "Property",
30+
"value": "36L/18R"
31+
},
32+
"lengthMeters": {
33+
"type": "Property",
34+
"value": 4350.0
35+
},
36+
"widthMeters": {
37+
"type": "Property",
38+
"value": 60.0
39+
},
1340
"location": {
14-
"type": "LineString",
15-
"coordinates": [
16-
[
17-
-3.5786,
18-
40.4851
19-
],
20-
[
21-
-3.5784,
22-
40.5244
41+
"type": "GeoProperty",
42+
"value": {
43+
"type": "LineString",
44+
"coordinates": [
45+
[
46+
-3.5786,
47+
40.4851
48+
],
49+
[
50+
-3.5784,
51+
40.5244
52+
]
2353
]
54+
}
55+
},
56+
"source": {
57+
"type": "Property",
58+
"value": "https://www.openstreetmap.org"
59+
},
60+
"seeAlso": {
61+
"type": "Property",
62+
"value": [
63+
"https://www.openstreetmap.org/way/123123123"
2464
]
2565
},
26-
"source": "https://www.openstreetmap.org",
27-
"seeAlso": [
28-
"https://www.openstreetmap.org/way/123123123"
66+
"@context": [
67+
"https://raw.githubusercontent.com/smart-data-models/dataModel.OpenStreetMap/refs/heads/master/context.jsonld"
2968
]
3069
}

‎dataModel.OpenStreetMap/OSMAeroway/examples/example.jsonld‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,8 @@
2626
"source": "https://www.openstreetmap.org",
2727
"seeAlso": [
2828
"https://www.openstreetmap.org/way/123123123"
29+
],
30+
"@context": [
31+
"https://raw.githubusercontent.com/smart-data-models/dataModel.OpenStreetMap/refs/heads/master/context.jsonld"
2932
]
3033
}

‎dataModel.OpenStreetMap/OSMAeroway/notes.yaml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
---

‎dataModel.OpenStreetMap/OSMAeroway/recommendations_20260522_0200.md‎

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
# Smart Data Models — Review Report: OSMAeroway
2+
3+
**Date:** 2026-05-22 02:00 UTC
4+
**Schema version:** 0.0.1
5+
**Model path:** incubated/dataModel.OpenStreetMap/OSMAeroway
6+
**Status:** ✅ READY FOR PUBLICATION
7+
8+
All 12 validation tests passed. Corrected files have been committed to the incubated
9+
repository and a publication request has been sent to alberto.abella@transparentia.net.
10+
11+
---
12+
13+
## Test Results
14+
15+
| Test | Result |
16+
|------|--------|
17+
| test_file_exists | ✅ PASS |
18+
| test_valid_json | ✅ PASS |
19+
| test_yaml_files | ✅ PASS |
20+
| test_schema_descriptions | ✅ PASS |
21+
| test_schema_metadata | ✅ PASS |
22+
| test_string_incorrect | ✅ PASS |
23+
| test_valid_keyvalues_examples | ✅ PASS |
24+
| test_valid_ngsiv2 | ✅ PASS |
25+
| test_valid_ngsild | ✅ PASS |
26+
| test_duplicated_attributes | ✅ PASS |
27+
| test_array_object_structure | ✅ PASS |
28+
| test_name_attributes | ✅ PASS |
29+
30+
---
31+
32+
## Auto-generated Files Removed
33+
34+
None
35+
36+
---
37+
38+
## Auto-fixes Applied
39+
40+
- **[Fix G]** Scaffolded missing `ADOPTERS.yaml` and `notes.yaml`
41+
- **[Fix examples]** Regenerated `example.jsonld` (added `@context`), `example-normalized.json` (NGSIv2 normalized format), `example-normalized.jsonld` (NGSI-LD normalized format)
42+
- **[Fix B]** Added `required: ["id", "type"]` to `schema.json`
43+
44+
---
45+
46+
## Warnings (non-blocking)
47+
48+
- test_schema_metadata: `$id` URL not yet reachable — expected for unpublished model
49+
- test_schema_metadata: `license` is missing
50+
51+
---
52+
53+
## Contribution Agreement Reminder
54+
55+
⚠️ Please ensure the contributor has signed the Smart Data Models Contribution Agreement
56+
before publication is finalised:
57+
https://smartdatamodels.org/index.php/contributor-agreement/

‎dataModel.OpenStreetMap/OSMAeroway/schema.json‎

Lines changed: 45 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@
1818
"properties": {
1919
"type": {
2020
"type": "string",
21-
"enum": ["OSMAeroway"],
21+
"enum": [
22+
"OSMAeroway"
23+
],
2224
"description": "Property. NGSI Entity type. It has to be OSMAeroway"
2325
},
2426
"osmId": {
@@ -27,7 +29,11 @@
2729
},
2830
"osmType": {
2931
"type": "string",
30-
"enum": ["node", "way", "relation"],
32+
"enum": [
33+
"node",
34+
"way",
35+
"relation"
36+
],
3137
"description": "Property. The type of the original OpenStreetMap element."
3238
},
3339
"osmLastModified": {
@@ -38,8 +44,18 @@
3844
"aerowayType": {
3945
"type": "string",
4046
"enum": [
41-
"aerodrome", "apron", "gate", "hangar", "helipad", "heliport", "runway", "taxiway", "terminal",
42-
"windsock", "holding_position", "navigationaid"
47+
"aerodrome",
48+
"apron",
49+
"gate",
50+
"hangar",
51+
"helipad",
52+
"heliport",
53+
"runway",
54+
"taxiway",
55+
"terminal",
56+
"windsock",
57+
"holding_position",
58+
"navigationaid"
4359
],
4460
"description": "Property. The OSM aeroway tag classifying the feature. Model:'https://wiki.openstreetmap.org/wiki/Key:aeroway'"
4561
},
@@ -69,13 +85,34 @@
6985
},
7086
"seeAlso": {
7187
"oneOf": [
72-
{"type": "array", "items": {"type": "string", "format": "uri"}, "minItems": 1},
73-
{"type": "string", "format": "uri"}
88+
{
89+
"type": "array",
90+
"items": {
91+
"type": "string",
92+
"format": "uri"
93+
},
94+
"minItems": 1
95+
},
96+
{
97+
"type": "string",
98+
"format": "uri"
99+
}
74100
],
75101
"description": "Property. List of URIs pointing to additional resources about this item."
76102
}
77103
},
78-
"required": ["id", "type", "location", "osmId", "osmType", "aerowayType"]
104+
"required": [
105+
"id",
106+
"type",
107+
"location",
108+
"osmId",
109+
"osmType",
110+
"aerowayType"
111+
]
79112
}
113+
],
114+
"required": [
115+
"id",
116+
"type"
80117
]
81-
}
118+
}

‎dataModel.OpenStreetMap/OSMBarrier/ADOPTERS.yaml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
---

0 commit comments

Comments
 (0)