Skip to content

Commit 27c8f28

Browse files
johnml1135claude
andcommitted
Remove two tests for reverted custom-fields fwlayout additions
Two FullEntryRegionComposerCustomFieldTests methods (compose and edit) depended on the customFields="here" additions to LexEntry.fwlayout/LexSense.fwlayout that were pulled out of this PR earlier (see PR #1010). Same class of miss as the earlier XmlVc.cs revert: the production change was reverted but its companion tests were not, breaking CI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 245b6b3 commit 27c8f28

1 file changed

Lines changed: 0 additions & 66 deletions

File tree

Src/xWorks/xWorksTests/LexicalEditRegionEditingTests.cs

Lines changed: 0 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -2266,28 +2266,6 @@ public void Compose_CustomFields_ExpandInNestedAllomorphAndExampleLayouts()
22662266
Assert.That(affixCustom.Values.Single().Value, Is.EqualTo("affix allomorph note"));
22672267
}
22682268

2269-
[Test]
2270-
public void Compose_CustomFields_ExpandInPreviouslyMissingNestedDetailLayouts()
2271-
{
2272-
var fields = Compose();
2273-
Assert.That(fields.Any(f => f.Label == "Pronunciation Note" && f.ObjectHvo == m_pronunciation.Hvo),
2274-
Is.True, "pronunciation custom fields should render in the pronunciation detail layout");
2275-
Assert.That(fields.Any(f => f.Label == "Etymology Note" && f.ObjectHvo == m_etymology.Hvo),
2276-
Is.True, "etymology custom fields should render in the etymology detail layout");
2277-
Assert.That(fields.Any(f => f.Label == "Entry Ref Note" && f.ObjectHvo == m_entryRef.Hvo),
2278-
Is.True, "entry-reference custom fields should render in the entry-ref detail layout");
2279-
Assert.That(fields.Any(f => f.Label == "Extended Note Custom" && f.ObjectHvo == m_extendedNote.Hvo),
2280-
Is.True, "extended-note custom fields should render in the extended-note detail layout");
2281-
Assert.That(fields.Any(f => f.Label == "Example Note" && f.ObjectHvo == m_noteExample.Hvo),
2282-
Is.True, "the example Notes layout should render LexExampleSentence custom fields");
2283-
Assert.That(fields.Any(f => f.Label == "Translation Note" && f.ObjectHvo == m_translation.Hvo),
2284-
Is.True, "translation custom fields should render in the TranslationAndType layout");
2285-
Assert.That(fields.Any(f => f.Label == "Translation Note" && f.ObjectHvo == m_noteTranslation.Hvo),
2286-
Is.True, "translation custom fields should render in the Translation layout used by note examples");
2287-
Assert.That(fields.Any(f => f.Label == "Picture Note" && f.ObjectHvo == m_picture.Hvo),
2288-
Is.True, "picture custom fields should render in the picture detail layout");
2289-
}
2290-
22912269
[Test]
22922270
public void Edit_CustomFields_StageThroughTheFencedSession_AsOneUndoStep()
22932271
{
@@ -2387,50 +2365,6 @@ public void Edit_CustomFields_OnNestedAllomorphAndExampleLayouts_StageThroughThe
23872365
Assert.That(sda.get_VecSize(m_example.Hvo, m_flidExampleListVector), Is.EqualTo(2));
23882366
}
23892367

2390-
[Test]
2391-
public void Edit_CustomFields_OnPreviouslyMissingNestedDetailLayouts_StageThroughTheFencedSession()
2392-
{
2393-
var composed = FullEntryRegionComposer.Compose(m_entry, Cache);
2394-
var pron = composed.Model.Fields.First(f => f.Label == "Pronunciation Note" && f.ObjectHvo == m_pronunciation.Hvo);
2395-
var etym = composed.Model.Fields.First(f => f.Label == "Etymology Note" && f.ObjectHvo == m_etymology.Hvo);
2396-
var entryRef = composed.Model.Fields.First(f => f.Label == "Entry Ref Note" && f.ObjectHvo == m_entryRef.Hvo);
2397-
var extNote = composed.Model.Fields.First(f => f.Label == "Extended Note Custom" && f.ObjectHvo == m_extendedNote.Hvo);
2398-
var noteExample = composed.Model.Fields.First(f => f.Label == "Example Note" && f.ObjectHvo == m_noteExample.Hvo);
2399-
var translation = composed.Model.Fields.First(f => f.Label == "Translation Note" && f.ObjectHvo == m_translation.Hvo);
2400-
var noteTranslation = composed.Model.Fields.First(f => f.Label == "Translation Note" && f.ObjectHvo == m_noteTranslation.Hvo);
2401-
var picture = composed.Model.Fields.First(f => f.Label == "Picture Note" && f.ObjectHvo == m_picture.Hvo);
2402-
var sda = Cache.DomainDataByFlid;
2403-
2404-
Assert.That(composed.EditContext.TrySetText(pron, pron.Values.Single().WsTag, "pron note edited"), Is.True);
2405-
Assert.That(composed.EditContext.TrySetText(etym, etym.Values.Single().WsTag, "etym note edited"), Is.True);
2406-
Assert.That(composed.EditContext.TrySetText(entryRef, entryRef.Values.Single().WsTag, "entry ref edited"), Is.True);
2407-
Assert.That(composed.EditContext.TrySetText(extNote, extNote.Values.Single().WsTag, "extended note edited"), Is.True);
2408-
Assert.That(composed.EditContext.TrySetText(noteExample, noteExample.Values.Single().WsTag, "note example edited"), Is.True);
2409-
Assert.That(composed.EditContext.TrySetText(translation, translation.Values.Single().WsTag, "translation edited"), Is.True);
2410-
Assert.That(composed.EditContext.TrySetText(noteTranslation, noteTranslation.Values.Single().WsTag, "note translation edited"), Is.True);
2411-
Assert.That(composed.EditContext.TrySetText(picture, picture.Values.Single().WsTag, "picture edited"), Is.True);
2412-
composed.EditContext.Commit();
2413-
2414-
Assert.That(sda.get_StringProp(m_pronunciation.Hvo, m_flidPronunciationSingle).Text, Is.EqualTo("pron note edited"));
2415-
Assert.That(sda.get_StringProp(m_etymology.Hvo, m_flidEtymologySingle).Text, Is.EqualTo("etym note edited"));
2416-
Assert.That(sda.get_StringProp(m_entryRef.Hvo, m_flidEntryRefSingle).Text, Is.EqualTo("entry ref edited"));
2417-
Assert.That(sda.get_StringProp(m_extendedNote.Hvo, m_flidExtendedNoteSingle).Text, Is.EqualTo("extended note edited"));
2418-
Assert.That(sda.get_StringProp(m_noteExample.Hvo, m_flidExampleSingle).Text, Is.EqualTo("note example edited"));
2419-
Assert.That(sda.get_StringProp(m_translation.Hvo, m_flidTranslationSingle).Text, Is.EqualTo("translation edited"));
2420-
Assert.That(sda.get_StringProp(m_noteTranslation.Hvo, m_flidTranslationSingle).Text, Is.EqualTo("note translation edited"));
2421-
Assert.That(sda.get_StringProp(m_picture.Hvo, m_flidPictureSingle).Text, Is.EqualTo("picture edited"));
2422-
2423-
Cache.ActionHandlerAccessor.Undo();
2424-
Assert.That(sda.get_StringProp(m_pronunciation.Hvo, m_flidPronunciationSingle).Text, Is.EqualTo("pron note"));
2425-
Assert.That(sda.get_StringProp(m_etymology.Hvo, m_flidEtymologySingle).Text, Is.EqualTo("etymology note"));
2426-
Assert.That(sda.get_StringProp(m_entryRef.Hvo, m_flidEntryRefSingle).Text, Is.EqualTo("entry ref note"));
2427-
Assert.That(sda.get_StringProp(m_extendedNote.Hvo, m_flidExtendedNoteSingle).Text, Is.EqualTo("extended note custom"));
2428-
Assert.That(sda.get_StringProp(m_noteExample.Hvo, m_flidExampleSingle).Text, Is.EqualTo("extended note example"));
2429-
Assert.That(sda.get_StringProp(m_translation.Hvo, m_flidTranslationSingle).Text, Is.EqualTo("translation custom"));
2430-
Assert.That(sda.get_StringProp(m_noteTranslation.Hvo, m_flidTranslationSingle).Text, Is.EqualTo("note translation custom"));
2431-
Assert.That(sda.get_StringProp(m_picture.Hvo, m_flidPictureSingle).Text, Is.EqualTo("picture note"));
2432-
}
2433-
24342368
// Review task 5: a plain String prop reads the WHOLE string (get_StringProp), so the
24352369
// row's writing system must come from the STRING's own first run when there is content —
24362370
// not from the layout's ws= spec — and write-back must use that same ws (legacy

0 commit comments

Comments
 (0)