Skip to content

configure_keyper.sh unintentionally sets P2P.FloodSubDiscovery.Enabled #67

@jannikluhn

Description

@jannikluhn

In _container_scripts/configure_keyper.sh, the line that sets the metrics Enabled flag uses an overly broad pattern:

sed -i "/^Enabled/c\Enabled = ${SHUTTER_METRICS_ENABLED}" $CFG

config.toml contains two keys named Enabled at the top level of their respective sections:

[P2P.FloodSubDiscovery]
Enabled = false   # ← also matched

[Metrics]
Enabled = false   # ← intended target

Because sed applies the substitution to every line matching ^Enabled, the [P2P.FloodSubDiscovery] setting is unconditionally overwritten with the value of SHUTTER_METRICS_ENABLED.

To fix this, the pattern can be made more strict. Alternatively, the script could be rewritten to use a proper TOML editing tool.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions