Triage 11 commits

delan · delan · commit ca5b8bf92d84 · 2026-06-16T00:13:53.000+08:00
diff --git a/commits.txt b/commits.txt
@@ -658,7 +658,8 @@ https://github.com/servo/servo/pull/44702	(@shubhamg13, #44702)	script: Implemen
     # 
     # Testing: More WPT Passed
     # 
-https://github.com/servo/servo/pull/44707	(@Narfinger, #44707)	script: Fix unit test panic for domstring test for release profile (#44707)
+-https://github.com/servo/servo/pull/44707	(@Narfinger, #44707)	script: Fix unit test panic for domstring test for release profile (#44707)
+    ;test; test only
     ^ commit 548260c084b1c5a94cd74922629171b2cfd00c75
     # A unit test in domstring was relying on debug_asserts to panic. This broke with a recent change to unit tests in release mode.
     # 
@@ -686,7 +687,8 @@ https://github.com/servo/servo/pull/44705	(@shubhamg13, #44705)	Enable feature `
     # 
     # Testing: Tested Locally
     # Fixes: #44711 
-https://github.com/servo/servo/pull/44598	(@Narfinger, #44598)	script: Move DomRefCell, assert_in_* into script_bindings (#44598)
++https://github.com/servo/servo/pull/44598	(@Narfinger, #44598)	script: Move DomRefCell, assert_in_* into script_bindings (#44598)
+    script; move more code out of script crate
     ^ commit 474ee1726ce7df3c2314051264ab3c8612c076ad
     # As part of splitting up the Script crate this moves DomRefCell (and related) into script_bindings. Also it moves assert_in_script and assert_in_layout, similarly.
     # As the diff is quite large, the major files are
@@ -712,7 +714,8 @@ https://github.com/servo/servo/pull/44713	(@jschwe, #44713)	ohos ci: Set PYTHONU
     # Fixes: #43235
     # Fixes: #43255 
     # 
-https://github.com/servo/servo/pull/44690	(@Loirooriol, #44690)	Upgrade Stylo to 2026-05-01 (#44690)
++https://github.com/servo/servo/pull/44690	(@Loirooriol, #44690)	Upgrade Stylo to 2026-05-01 (#44690)
+    security perf style; attr() can no longer be used in url(). faster cascade if only non-inherited properties change (not for standard properties yet). more conformant <color> values
     ^ commit 58dcc26ec4c4c7645db72ebe7b0038002b0d347c
     ^ /!\ contains changes to WPT expectations! it probably affects the web platform
     # This continues  #43878
@@ -736,7 +739,8 @@ https://github.com/servo/servo/pull/44690	(@Loirooriol, #44690)	Upgrade Stylo to
     # 
     # Testing: It compiles.
     # 
-https://github.com/servo/servo/pull/44718	(@Narfinger, #44718)	script: Remove accountable_refcell and refcell_backtrace feature (#44718)
++https://github.com/servo/servo/pull/44718	(@Narfinger, #44718)	script: Remove accountable_refcell and refcell_backtrace feature (#44718)
+    cleanup; script cleanup
     ^ commit d6d11195c8f31db9c38d3a1d91b756b7d2b7e586
     ^ /!\ contains libservo or embedder_traits changes! does it affect our public API?
     ^ /!\ contains servoshell changes! does it affect the user experience?
@@ -2482,7 +2486,8 @@ https://github.com/servo/servo/pull/44787	(@gterzian, #44787)	script: Remove cli
     # Testing: WPT
     # Fixes: None
     # 
-https://github.com/servo/servo/pull/44797	(@Onyeka.Obi@gmail.com, #44797)	script: Use let/else in `GlobalScope::broadcast_message_event`. (#44797)
++https://github.com/servo/servo/pull/44797	(@Onyeka.Obi@gmail.com, #44797)	script: Use let/else in `GlobalScope::broadcast_message_event`. (#44797)
+    cleanup; script cleanup
     ^ commit 066fb6a85a10e8aedb1a367589bcab31e815ea22
     # Replace the outer `if let BroadcastChannelState::Managed(_, channels)` guard with `let ... else { return; };`, un-indenting the rest of the method.  Matches the existing pattern at `note_cross_realm_transform_readable` in the same file.
     # 
@@ -2759,7 +2764,8 @@ https://github.com/servo/servo/pull/44827	(@sagudev, #44827)	webgpu: fixup GPUBu
     # 
     # Testing: Tests now pass
     # 
-https://github.com/servo/servo/pull/44829	(@SharanRP, #44829)	Remove stale temp_cx in consume_body (#44829)
++https://github.com/servo/servo/pull/44829	(@SharanRP, #44829)	Remove stale temp_cx in consume_body (#44829)
+    cleanup; script cleanup
     ^ commit 2f8b04406fab93fb17e5a5e0594a86bddb665f3f
     # Removed the `stale temp_cx()` call inside consume_body, the cx obtained from `realm.current_realm()`  is already available and properly used throughout the function, the temporary cx was unnecessarily shadowing the original context
     # 
@@ -3160,7 +3166,8 @@ https://github.com/servo/servo/pull/44852	(@Gae24, #44852)	net: drop `HttpsState
     # 
     # Testing: It compiles
     # 
-https://github.com/servo/servo/pull/44856	(@Loirooriol, #44856)	stylo: Resolve `<color>` values in getComputedStyle for registered custom properties (#44856)
++https://github.com/servo/servo/pull/44856	(@Loirooriol, #44856)	stylo: Resolve `<color>` values in getComputedStyle for registered custom properties (#44856)
+    style; more conformant getComputedStyle() with registered custom properties
     ^ commit a8d492fb51712e3410a5e67f4db2bf08b2434873
     ^ /!\ contains changes to WPT expectations! it probably affects the web platform
     # Bumps Stylo to https://github.com/servo/stylo/pull/360
@@ -4312,7 +4319,8 @@ https://github.com/servo/servo/pull/44921	(@yezhizhen, #44921)	script: Interpret
     # Testing: New passing in existing. Added a new test for `FileReaderSync` too.
     # 
     # Part of #10778
-https://github.com/servo/servo/pull/44922	(@Gae24, #44922)	servoshell: Fix warnings and remove unused portions of the Gradle configuration (#44922)
++https://github.com/servo/servo/pull/44922	(@Gae24, #44922)	servoshell: Fix warnings and remove unused portions of the Gradle configuration (#44922)
+    cleanup; servoshell cleanup
     ^ commit 553e959047ed838bea43245d589dd6e26f00a97b
     # Removed stale blurdroid  and libsimpleservo references from `servoview/build.gradle.kts` and fixed a couple warnings.
     # 
@@ -4373,7 +4381,8 @@ https://github.com/servo/servo/pull/44926	(@simonwuelker, #44926)	script: Don't
     # The only caller of `BroadcastChannel::new` is the in-file `Constructor`, so no propagation beyond this file is required.
     # 
     # Testing: it compiles
-https://github.com/servo/servo/pull/44934	(@simonwuelker, #44934)	mach: Remove references to nonexistent `busted` subcommand (#44934)
+-https://github.com/servo/servo/pull/44934	(@simonwuelker, #44934)	mach: Remove references to nonexistent `busted` subcommand (#44934)
+    ;dev; tooling papercut
     ^ commit 5fa853017458deaf93b93e91b01d3251ad1756cf
     # Closes https://github.com/servo/servo/issues/33560
 >>> 2026-05-16T00:12:12Z
@@ -4486,7 +4495,8 @@ https://github.com/servo/servo/pull/44945	(@mrobinson, #44945)	layout: Stop clon
     # Testing: There are currently no automated performance tests sadly, but this
     # change shouldn't change observable behavior.
     # 
-https://github.com/servo/servo/pull/44932	(@Gae24, #44932)	servoshell: further cleanup android project (#44932)
++https://github.com/servo/servo/pull/44932	(@Gae24, #44932)	servoshell: further cleanup android project (#44932)
+    cleanup; servoshell cleanup
     ^ commit 56dc76cdb2125206d98ddf0da89f31b4cab8149d
     # Follow up of #44922. 
     # 
@@ -5286,7 +5296,8 @@ https://github.com/servo/servo/pull/45051	(@freyacodes, #45051)	shell.nix: Updat
     # 
     # Testing: Refactoring. Existing tests are enough.
     # Fixes: Follow-up of https://github.com/servo/servo/pull/44983#discussion_r3257878902
-https://github.com/servo/servo/pull/45052	(@Gae24, #45052)	script: Inline some event dispatching methods (#45052)
++https://github.com/servo/servo/pull/45052	(@Gae24, #45052)	script: Inline some event dispatching methods (#45052)
+    cleanup; script cleanup
     ^ commit a62701df330062eaa050190fbdab40b573c91696
     # Noticed this a while ago, event dispatching code would go back and forth between `Event` and `EventTarget`, thus some of the methods are now inlined.
     # 

Original file line number	Diff line number	Diff line change
`@@ -658,7 +658,8 @@ https://github.com/servo/servo/pull/44702 (@shubhamg13, #44702) script: Implemen`
`658`	`658`	`#`
`659`	`659`	`# Testing: More WPT Passed`
`660`	`660`	`#`
`661`		`-https://github.com/servo/servo/pull/44707 (@Narfinger, #44707) script: Fix unit test panic for domstring test for release profile (#44707)`
	`661`	`+-https://github.com/servo/servo/pull/44707 (@Narfinger, #44707) script: Fix unit test panic for domstring test for release profile (#44707)`
	`662`	`+ ;test; test only`
`662`	`663`	`^ commit 548260c084b1c5a94cd74922629171b2cfd00c75`
`663`	`664`	`# A unit test in domstring was relying on debug_asserts to panic. This broke with a recent change to unit tests in release mode.`
`664`	`665`	`#`
@@ -686,7 +687,8 @@ https://github.com/servo/servo/pull/44705 (@shubhamg13, #44705) Enable feature `
`686`	`687`	`#`
`687`	`688`	`# Testing: Tested Locally`
`688`	`689`	`# Fixes: #44711`
`689`		`-https://github.com/servo/servo/pull/44598 (@Narfinger, #44598) script: Move DomRefCell, assert_in_* into script_bindings (#44598)`
	`690`	`++https://github.com/servo/servo/pull/44598 (@Narfinger, #44598) script: Move DomRefCell, assert_in_* into script_bindings (#44598)`
	`691`	`+ script; move more code out of script crate`
`690`	`692`	`^ commit 474ee1726ce7df3c2314051264ab3c8612c076ad`
`691`	`693`	`# As part of splitting up the Script crate this moves DomRefCell (and related) into script_bindings. Also it moves assert_in_script and assert_in_layout, similarly.`
`692`	`694`	`# As the diff is quite large, the major files are`
`@@ -712,7 +714,8 @@ https://github.com/servo/servo/pull/44713 (@jschwe, #44713) ohos ci: Set PYTHONU`
`712`	`714`	`# Fixes: #43235`
`713`	`715`	`# Fixes: #43255`
`714`	`716`	`#`
`715`		`-https://github.com/servo/servo/pull/44690 (@Loirooriol, #44690) Upgrade Stylo to 2026-05-01 (#44690)`
	`717`	`++https://github.com/servo/servo/pull/44690 (@Loirooriol, #44690) Upgrade Stylo to 2026-05-01 (#44690)`
	`718`	`+ security perf style; attr() can no longer be used in url(). faster cascade if only non-inherited properties change (not for standard properties yet). more conformant <color> values`
`716`	`719`	`^ commit 58dcc26ec4c4c7645db72ebe7b0038002b0d347c`
`717`	`720`	`^ /!\ contains changes to WPT expectations! it probably affects the web platform`
`718`	`721`	`# This continues #43878`
`@@ -736,7 +739,8 @@ https://github.com/servo/servo/pull/44690 (@Loirooriol, #44690) Upgrade Stylo to`
`736`	`739`	`#`
`737`	`740`	`# Testing: It compiles.`
`738`	`741`	`#`
`739`		`-https://github.com/servo/servo/pull/44718 (@Narfinger, #44718) script: Remove accountable_refcell and refcell_backtrace feature (#44718)`
	`742`	`++https://github.com/servo/servo/pull/44718 (@Narfinger, #44718) script: Remove accountable_refcell and refcell_backtrace feature (#44718)`
	`743`	`+ cleanup; script cleanup`
`740`	`744`	`^ commit d6d11195c8f31db9c38d3a1d91b756b7d2b7e586`
`741`	`745`	`^ /!\ contains libservo or embedder_traits changes! does it affect our public API?`
`742`	`746`	`^ /!\ contains servoshell changes! does it affect the user experience?`
`@@ -2482,7 +2486,8 @@ https://github.com/servo/servo/pull/44787 (@gterzian, #44787) script: Remove cli`
`2482`	`2486`	`# Testing: WPT`
`2483`	`2487`	`# Fixes: None`
`2484`	`2488`	`#`
`2485`		-https://github.com/servo/servo/pull/44797 (@Onyeka.Obi@gmail.com, #44797) script: Use let/else in `GlobalScope::broadcast_message_event`. (#44797)
	`2489`	++https://github.com/servo/servo/pull/44797 (@Onyeka.Obi@gmail.com, #44797) script: Use let/else in `GlobalScope::broadcast_message_event`. (#44797)
	`2490`	`+ cleanup; script cleanup`
`2486`	`2491`	`^ commit 066fb6a85a10e8aedb1a367589bcab31e815ea22`
`2487`	`2492`	# Replace the outer `if let BroadcastChannelState::Managed(_, channels)` guard with `let ... else { return; };`, un-indenting the rest of the method. Matches the existing pattern at `note_cross_realm_transform_readable` in the same file.
`2488`	`2493`	`#`
`@@ -2759,7 +2764,8 @@ https://github.com/servo/servo/pull/44827 (@sagudev, #44827) webgpu: fixup GPUBu`
`2759`	`2764`	`#`
`2760`	`2765`	`# Testing: Tests now pass`
`2761`	`2766`	`#`
`2762`		`-https://github.com/servo/servo/pull/44829 (@SharanRP, #44829) Remove stale temp_cx in consume_body (#44829)`
	`2767`	`++https://github.com/servo/servo/pull/44829 (@SharanRP, #44829) Remove stale temp_cx in consume_body (#44829)`
	`2768`	`+ cleanup; script cleanup`
`2763`	`2769`	`^ commit 2f8b04406fab93fb17e5a5e0594a86bddb665f3f`
`2764`	`2770`	# Removed the `stale temp_cx()` call inside consume_body, the cx obtained from `realm.current_realm()` is already available and properly used throughout the function, the temporary cx was unnecessarily shadowing the original context
`2765`	`2771`	`#`
@@ -3160,7 +3166,8 @@ https://github.com/servo/servo/pull/44852 (@Gae24, #44852) net: drop `HttpsState
`3160`	`3166`	`#`
`3161`	`3167`	`# Testing: It compiles`
`3162`	`3168`	`#`
`3163`		-https://github.com/servo/servo/pull/44856 (@Loirooriol, #44856) stylo: Resolve `<color>` values in getComputedStyle for registered custom properties (#44856)
	`3169`	++https://github.com/servo/servo/pull/44856 (@Loirooriol, #44856) stylo: Resolve `<color>` values in getComputedStyle for registered custom properties (#44856)
	`3170`	`+ style; more conformant getComputedStyle() with registered custom properties`
`3164`	`3171`	`^ commit a8d492fb51712e3410a5e67f4db2bf08b2434873`
`3165`	`3172`	`^ /!\ contains changes to WPT expectations! it probably affects the web platform`
`3166`	`3173`	`# Bumps Stylo to https://github.com/servo/stylo/pull/360`
`@@ -4312,7 +4319,8 @@ https://github.com/servo/servo/pull/44921 (@yezhizhen, #44921) script: Interpret`
`4312`	`4319`	# Testing: New passing in existing. Added a new test for `FileReaderSync` too.
`4313`	`4320`	`#`
`4314`	`4321`	`# Part of #10778`
`4315`		`-https://github.com/servo/servo/pull/44922 (@Gae24, #44922) servoshell: Fix warnings and remove unused portions of the Gradle configuration (#44922)`
	`4322`	`++https://github.com/servo/servo/pull/44922 (@Gae24, #44922) servoshell: Fix warnings and remove unused portions of the Gradle configuration (#44922)`
	`4323`	`+ cleanup; servoshell cleanup`
`4316`	`4324`	`^ commit 553e959047ed838bea43245d589dd6e26f00a97b`
`4317`	`4325`	# Removed stale blurdroid and libsimpleservo references from `servoview/build.gradle.kts` and fixed a couple warnings.
`4318`	`4326`	`#`
`@@ -4373,7 +4381,8 @@ https://github.com/servo/servo/pull/44926 (@simonwuelker, #44926) script: Don't`
`4373`	`4381`	# The only caller of `BroadcastChannel::new` is the in-file `Constructor`, so no propagation beyond this file is required.
`4374`	`4382`	`#`
`4375`	`4383`	`# Testing: it compiles`
`4376`		-https://github.com/servo/servo/pull/44934 (@simonwuelker, #44934) mach: Remove references to nonexistent `busted` subcommand (#44934)
	`4384`	+-https://github.com/servo/servo/pull/44934 (@simonwuelker, #44934) mach: Remove references to nonexistent `busted` subcommand (#44934)
	`4385`	`+ ;dev; tooling papercut`
`4377`	`4386`	`^ commit 5fa853017458deaf93b93e91b01d3251ad1756cf`
`4378`	`4387`	`# Closes https://github.com/servo/servo/issues/33560`
`4379`	`4388`	`>>> 2026-05-16T00:12:12Z`
`@@ -4486,7 +4495,8 @@ https://github.com/servo/servo/pull/44945 (@mrobinson, #44945) layout: Stop clon`
`4486`	`4495`	`# Testing: There are currently no automated performance tests sadly, but this`
`4487`	`4496`	`# change shouldn't change observable behavior.`
`4488`	`4497`	`#`
`4489`		`-https://github.com/servo/servo/pull/44932 (@Gae24, #44932) servoshell: further cleanup android project (#44932)`
	`4498`	`++https://github.com/servo/servo/pull/44932 (@Gae24, #44932) servoshell: further cleanup android project (#44932)`
	`4499`	`+ cleanup; servoshell cleanup`
`4490`	`4500`	`^ commit 56dc76cdb2125206d98ddf0da89f31b4cab8149d`
`4491`	`4501`	`# Follow up of #44922.`
`4492`	`4502`	`#`
`@@ -5286,7 +5296,8 @@ https://github.com/servo/servo/pull/45051 (@freyacodes, #45051) shell.nix: Updat`
`5286`	`5296`	`#`
`5287`	`5297`	`# Testing: Refactoring. Existing tests are enough.`
`5288`	`5298`	`# Fixes: Follow-up of https://github.com/servo/servo/pull/44983#discussion_r3257878902`
`5289`		`-https://github.com/servo/servo/pull/45052 (@Gae24, #45052) script: Inline some event dispatching methods (#45052)`
	`5299`	`++https://github.com/servo/servo/pull/45052 (@Gae24, #45052) script: Inline some event dispatching methods (#45052)`
	`5300`	`+ cleanup; script cleanup`
`5290`	`5301`	`^ commit a62701df330062eaa050190fbdab40b573c91696`
`5291`	`5302`	# Noticed this a while ago, event dispatching code would go back and forth between `Event` and `EventTarget`, thus some of the methods are now inlined.
`5292`	`5303`	`#`