Replace empty for-loop with while in rootCauseMessage

pditommaso · claude · pditommaso · commit a6e4fcd697b8 · 2026-07-16T17:40:52.000+02:00
Co-Authored-By: Claude Opus 4.8 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/src/main/groovy/io/seqera/wave/service/request/ContainerRequestServiceImpl.groovy b/src/main/groovy/io/seqera/wave/service/request/ContainerRequestServiceImpl.groovy
@@ -156,7 +156,9 @@ class ContainerRequestServiceImpl implements ContainerRequestService {
 
     protected static String rootCauseMessage(Throwable t) {
         Throwable e = t
-        for( int i = 0; e.cause != null && e.cause != e && i < MAX_CAUSE_DEPTH; e = e.cause, i++ ) { }
+        int i = 0
+        while( e.cause != null && e.cause != e && ++i < MAX_CAUSE_DEPTH )
+            e = e.cause
         return e.message ?: e.class.simpleName
     }
 

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,9 @@ class ContainerRequestServiceImpl implements ContainerRequestService {`
`156`	`156`
`157`	`157`	`protected static String rootCauseMessage(Throwable t) {`
`158`	`158`	`Throwable e = t`
`159`		`- for( int i = 0; e.cause != null && e.cause != e && i < MAX_CAUSE_DEPTH; e = e.cause, i++ ) { }`
	`159`	`+ int i = 0`
	`160`	`+ while( e.cause != null && e.cause != e && ++i < MAX_CAUSE_DEPTH )`
	`161`	`+ e = e.cause`
`160`	`162`	`return e.message ?: e.class.simpleName`
`161`	`163`	`}`
`162`	`164`