Return direct image for durable requests on the V1 endpoint (#1090)

makeResponseV2 already returns the direct target-registry image for
freeze/mirror (durable) requests, but makeResponseV1 kept handing back
the Wave proxy token url. Since durable images are no longer served via
the proxy token path (see RouteHandler), V1 freeze clients pulling via
targetImage would 404. Resolve targetImage to the direct image for
durable requests on V1 too, matching V2.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: pditommaso

src/main/groovy/io/seqera/wave/util/ContainerHelper.groovy

@@ -116,7 +116,9 @@ class ContainerHelper {
     }
 
     static SubmitContainerTokenResponse makeResponseV1(ContainerRequest data, TokenData token, String waveImage) {
-        final target = waveImage
+        // freeze/mirror images are published to the target registry and must be pulled
+        // directly from there - the Wave proxy token path does not serve them (see RouteHandler)
+        final target = data.durable() ? data.containerImage : waveImage
         final build = data.buildNew ? data.buildId : null
         return new SubmitContainerTokenResponse(data.requestId, token.value, target, token.expiration, data.containerImage, build, null, null, null, null, null)
     }

src/test/groovy/io/seqera/wave/util/ContainerHelperTest.groovy

@@ -253,12 +253,36 @@ class ContainerHelperTest extends Specification {
         result.cached == null
         result.freeze == null
 
-        where: 
+        where:
         NEW_BUILD   | EXPECTED_BUILD_ID
         false       | null
         true        | '123'
     }
 
+    @Unroll
+    def 'should create response v1 for durable request returning the direct image' () {
+        given:
+        def data = ContainerRequest.of(
+                containerImage: 'quay.io/org/container:1.0',
+                freeze: IS_FREEZE,
+                type: TYPE )
+        def token = new TokenData('123abc', Instant.now().plusSeconds(100))
+        def target = 'wave.com/wt/123abc/org/container:1.0'
+
+        when:
+        def result = ContainerHelper.makeResponseV1(data, token, target)
+        then:
+        // freeze/mirror images must resolve to the direct target-registry image,
+        // not the Wave proxy token url (which no longer serves durable images)
+        result.targetImage == 'quay.io/org/container:1.0'
+        result.containerImage == 'quay.io/org/container:1.0'
+
+        where:
+        TYPE                          | IS_FREEZE
+        null                          | true
+        ContainerRequest.Type.Mirror  | false
+    }
+
     @Unroll
     def 'should create response v2' () {
         given: