Skip to content

This plugin is not consistent with many of the practices followed by most plugins #175

@majormoses

Description

@majormoses

I see several things just looking around that we should change to bring it more inline with the way that all the other plugins are doing various things these are what I found when doing a release:

  • changelog does not follow the same format
  • the tags are all using the silly v$VERSION. Anyways not trying to start a religious war here, just pointing out areas in where there are differences and we should standardize where possible. As this is the outlier in 180+ plugins I vote we make the change here and not force a lot of extra work on converting everything over.
  • version is not broken out into its own file and is not setup the same way
  • does not have the standard travis config
  • does not auto deploy to rubygems on tag
  • does not have our standard Rakefile
  • does not have our standard rubocop config
  • sensu plugins user does not have access to push to rubygems. IMHO if you can merge there is no reason to not allow releasing.

I am sure there are plenty others...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions