Add save_resource function to save any file in demo bucket locally#2905
Open
frances-h wants to merge 2 commits into
Open
Add save_resource function to save any file in demo bucket locally#2905frances-h wants to merge 2 commits into
save_resource function to save any file in demo bucket locally#2905frances-h wants to merge 2 commits into
Conversation
frances-h
requested review from
gsheni and
sarahmish
and removed request for
a team
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2905 +/- ##
==========================================
+ Coverage 98.07% 98.09% +0.01%
==========================================
Files 73 73
Lines 8460 8483 +23
==========================================
+ Hits 8297 8321 +24
+ Misses 163 162 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gsheni
reviewed
Jun 8, 2026
| Save the file contents at this path. | ||
| bucket (str): | ||
| The name of the bucket to download from. Only 'sdv-datasets-public' is supported in | ||
| SDV Community. SDV Enterprise is required for other buckets. |
Contributor
There was a problem hiding this comment.
Does this work for SDV Enterprise and downloading README.txt / SOURCE.txt for a private dataset?
Contributor
Author
There was a problem hiding this comment.
Yeah, I can add additional integration tests to Enterprise and put up a PR with them
gsheni
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #2901