False positive in ControlStatementSpacing

[erikaxel]

Using slim-lint 0.33.0.

Given the following:

div class="a \
 b"
  - if 1 == 2
    | Hello

slim-lint gives the following false positive:

ControlStatementSpacing: Please add a space after the `-`

It seems to be related to the splitting of lines, because

div class="a b"
  - if 1 == 2
    | Hello

works fine with no warning.

[sds]

Might be relevant to @lovro-bikic's work in #199

[lovro-bikic]

Sorry for any inconvenience I might have caused!

I debugged this a bit and here's what I found: in the reported example ("Given the following:"), sexp.line is set to 2, while document.source_lines is:

[
  "div class=\"a \\",
  " b\"",
  "  - if 1 == 2",
  "    | Hello"
]

so this line of code returns the " b\"" line as the control statement line, which is not the case. The wrong line is inspected for offenses and reported.

When lines are not split (the "It seems to be related to the splitting of lines, because" example), sexp.line is still 2, while document.source_lines is:

[
  "div class=\"a b\"",
  "  - if 1 == 2",
  "    | Hello"
]

so now the control statement line is actually inspected.

@sds my domain knowledge here is weak, but shouldn't sexp.line return 3 in the first example?

Note that part of the linter which checks output statements also produces the same false positives, for example, like this:

div class="a \
  b"
  div = foo

[erikaxel]

I'm also not very familiar with this code base, but it seems like a fix for this was tried in #164, but reverted in #169 due to issue #168